From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: gpio_keys: Don't report events on gpio failure Date: Fri, 2 Oct 2015 10:44:33 -0700 Message-ID: <20151002174433.GD8437@dtor-ws> References: <1438048204-632-1-git-send-email-bjorn.andersson@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:33963 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbbJBRog (ORCPT ); Fri, 2 Oct 2015 13:44:36 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Linus Walleij Cc: Bjorn Andersson , Linux Input , "linux-kernel@vger.kernel.org" , John Stultz On Fri, Oct 02, 2015 at 03:34:45AM -0700, Linus Walleij wrote: > On Mon, Jul 27, 2015 at 6:50 PM, Bjorn Andersson > wrote: > > > In the cases where the gpio chip fails to acquire the current state an > > error is reported back to gpio_keys. This is currently interpreted as if > > the line went high, which just confuses the developer. > > > > This patch introduces an error print in this case and skipps the > > reporting of a input event; to aid in debugging this issue. > > > > Reported-by: John Stultz > > Signed-off-by: Bjorn Andersson > > Reviewed-by: Linus Walleij Applied, thank you. -- Dmitry