From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST Date: Fri, 2 Oct 2015 10:53:42 -0700 Message-ID: <20151002175342.GF8437@dtor-ws> References: <1443797278-9052-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:35816 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbbJBRxp (ORCPT ); Fri, 2 Oct 2015 13:53:45 -0400 Content-Disposition: inline In-Reply-To: <1443797278-9052-1-git-send-email-javier@osg.samsung.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Luis de Bethencourt , Hans de Goede , Linus Walleij , Scott Branden , Robin Gong , Lee Jones , Geert Uytterhoeven , Matt Ranostay , linux-input@vger.kernel.org, Frank Li On Fri, Oct 02, 2015 at 04:47:58PM +0200, Javier Martinez Canillas wrote: > The driver depends on GOLDFISH but there isn't a build dependency > so it's a good idea to allow the driver to be built even if that > option is disabled, if the COMPILE_TEST option is enabled. > > That way, the driver can be built with a config generated by make > allyesconfig and can be checked if a patch would break the build. > > Signed-off-by: Javier Martinez Canillas > Applied, thank you. > --- > > drivers/input/keyboard/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index 2e80107ff630..ddd8148d51d7 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG > module will be called samsung-keypad. > > config KEYBOARD_GOLDFISH_EVENTS > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > tristate "Generic Input Event device for Goldfish" > help > Say Y here to get an input event device for the Goldfish virtual > -- > 2.4.3 > -- Dmitry