From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 03/18] Input: cyttsp - use PTR_ERR_OR_ZERO() Date: Fri, 2 Oct 2015 11:21:55 -0700 Message-ID: <20151002182155.GP8437@dtor-ws> References: <1443793229-22363-1-git-send-email-javier@osg.samsung.com> <1443793229-22363-4-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:33494 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbbJBSV6 (ORCPT ); Fri, 2 Oct 2015 14:21:58 -0400 Content-Disposition: inline In-Reply-To: <1443793229-22363-4-git-send-email-javier@osg.samsung.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Ferruh Yigit , linux-input@vger.kernel.org On Fri, Oct 02, 2015 at 03:40:14PM +0200, Javier Martinez Canillas wrote: > The PTR_ERR_OR_ZERO() helper function checks if a pointer contains an > errno code and returns it or return 0 if that's not the case. Use the > helper instead of open coding the same logic in the driver. This was > found with make coccicheck that complains with the following warning: > > drivers/input/touchscreen/cyttsp4_i2c.c:53:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Signed-off-by: Javier Martinez Canillas Applied, thank you. > --- > > drivers/input/touchscreen/cyttsp4_i2c.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/cyttsp4_i2c.c b/drivers/input/touchscreen/cyttsp4_i2c.c > index a9f95c7d3c00..564e49002d5d 100644 > --- a/drivers/input/touchscreen/cyttsp4_i2c.c > +++ b/drivers/input/touchscreen/cyttsp4_i2c.c > @@ -50,10 +50,7 @@ static int cyttsp4_i2c_probe(struct i2c_client *client, > ts = cyttsp4_probe(&cyttsp4_i2c_bus_ops, &client->dev, client->irq, > CYTTSP4_I2C_DATA_SIZE); > > - if (IS_ERR(ts)) > - return PTR_ERR(ts); > - > - return 0; > + return PTR_ERR_OR_ZERO(ts); > } > > static int cyttsp4_i2c_remove(struct i2c_client *client) > -- > 2.4.3 > -- Dmitry