From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Ferruh Yigit <fery@cypress.com>,
Axel Lin <axel.lin@ingics.com>,
Pramod Gurav <pramod.gurav@smartplayin.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Heiko Stuebner <heiko.stuebner@bq.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Hans de Goede <hdegoede@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Rob Herring <robh@kernel.org>,
Dirk Behme <dirk.behme@de.bosch.com>,
Benson Leung <bleung@chromium.org>,
Shailendra Verma <shailendra.capricorn@gmail.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-input@vger.kernel.org, Duson Lin <dusonlin@emc.com.tw>,
Jingoo Han <jg1.han@samsung.com>,
Wolfram Sang <wsa@the-dreams.de>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Henrik Rydberg <rydberg@bitmath.org>,
Daniel Mack <linux@zonque.org>, Nick Dyer <nick.dyer@itdev.co.uk>,
Matt Ranostay <mranostay@gmail.com>
Subject: Re: [PATCH 00/18] Input - Fix make coccicheck warnings
Date: Fri, 2 Oct 2015 11:25:07 -0700 [thread overview]
Message-ID: <20151002182507.GQ8437@dtor-ws> (raw)
In-Reply-To: <1443793229-22363-1-git-send-email-javier@osg.samsung.com>
Hi Javier,
On Fri, Oct 02, 2015 at 03:40:11PM +0200, Javier Martinez Canillas wrote:
> Hello Dmitry,
>
> This series contains trivial patches with fixes to different warnings
> reported by make coccichek M=drivers/input.
>
> The patches don't contain functional changes but makes the functions
> simpler and removes unnecessary lines of code.
I disagree with some "simplify function return logic" patches: when
there are several actions that may fail I prefer explicit:
error = actionN();
if (error)
return error;
return 0;
even on the last one as it keep with the code flow and makes it easier
to move stuff around.
Please consider patches that not explicitly replied to as applied a
dropped.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-10-02 18:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 13:40 [PATCH 00/18] Input - Fix make coccicheck warnings Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 01/18] Input: joydev - use memdup_user() to duplicate memory from user-space Javier Martinez Canillas
2015-10-02 18:21 ` Dmitry Torokhov
2015-10-02 13:40 ` [PATCH 02/18] Input: ads7846 - use PTR_ERR_OR_ZERO() Javier Martinez Canillas
2015-10-02 18:21 ` Dmitry Torokhov
2015-10-02 13:40 ` [PATCH 03/18] Input: cyttsp " Javier Martinez Canillas
2015-10-02 18:21 ` Dmitry Torokhov
2015-10-02 13:40 ` [PATCH 04/18] Input: kxtj9 - remove unneeded retval variable Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 05/18] Input: retu-pwrbutton - simplify function return logic Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 06/18] Input: zforce " Javier Martinez Canillas
2015-10-02 13:54 ` Heiko Stübner
2015-10-02 18:15 ` Dmitry Torokhov
2015-10-02 13:40 ` [PATCH 07/18] Input: cap11xx " Javier Martinez Canillas
2015-10-02 13:41 ` Daniel Mack
2015-10-02 18:09 ` Dmitry Torokhov
2015-10-02 18:17 ` Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 08/18] Input: goldfish " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 09/18] Input: jornada720_ts " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 10/18] Input: intel-mid-touch " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 11/18] Input: da9034-ts " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 12/18] Input: pxa27x_keypad " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 13/18] Input: atmel_mxt_ts " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 14/18] Input: synaptics_i2c " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 15/18] Input: auo-pixcir-ts " Javier Martinez Canillas
2015-10-02 18:19 ` Dmitry Torokhov
2015-10-02 13:40 ` [PATCH 16/18] Input: elan_i2c " Javier Martinez Canillas
2015-10-02 16:46 ` Benson Leung
2015-10-02 13:40 ` [PATCH 17/18] Input: cypress_ps2 " Javier Martinez Canillas
2015-10-02 13:40 ` [PATCH 18/18] Input: tps6507x-ts " Javier Martinez Canillas
2015-10-02 18:20 ` Dmitry Torokhov
2015-10-02 18:25 ` Dmitry Torokhov [this message]
2015-10-03 11:13 ` [PATCH 00/18] Input - Fix make coccicheck warnings Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002182507.GQ8437@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@ingics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=dirk.behme@de.bosch.com \
--cc=dusonlin@emc.com.tw \
--cc=fabio.estevam@freescale.com \
--cc=fery@cypress.com \
--cc=hdegoede@redhat.com \
--cc=heiko.stuebner@bq.com \
--cc=javier@osg.samsung.com \
--cc=jg1.han@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@zonque.org \
--cc=mranostay@gmail.com \
--cc=nick.dyer@itdev.co.uk \
--cc=pramod.gurav@smartplayin.com \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
--cc=shailendra.capricorn@gmail.com \
--cc=wsa@the-dreams.de \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).