From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Hans Verkuil <hansverk@cisco.com>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
m.szyprowski@samsung.com, kyungmin.park@samsung.com,
thomas@tommie-lie.de, sean@mess.org, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
lars@opdenkamp.eu, kamil@wypas.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver
Date: Tue, 6 Oct 2015 00:11:10 +0100 [thread overview]
Message-ID: <20151005231109.GN21513@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <b55a5c1ff9318211aa472b28d03a978aad23770b.1441633456.git.hansverk@cisco.com>
On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote:
> + cec->adap = cec_create_adapter(&s5p_cec_adap_ops, cec,
> + CEC_NAME, CEC_CAP_STATE |
> + CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS | CEC_CAP_IO |
> + CEC_CAP_IS_SOURCE,
> + 0, THIS_MODULE, &pdev->dev);
> + ret = PTR_ERR_OR_ZERO(cec->adap);
> + if (ret)
> + return ret;
> + cec->adap->available_log_addrs = 1;
> +
> + platform_set_drvdata(pdev, cec);
> + pm_runtime_enable(dev);
This is really not a good interface.
"cec_create_adapter" creates and registers the adapter, at which point it
becomes available to userspace. However, you haven't finished setting it
up, so it's possible to nip in here and start using it before the setup
has completed. This needs fixing.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-05 23:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 13:44 [PATCHv9 00/15] HDMI CEC framework Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 01/15] dts: exynos4*: add HDMI CEC pin definition to pinctrl Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 02/15] dts: exynos4: add node for the HDMI CEC device Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 03/15] dts: exynos4412-odroid*: enable " Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 04/15] input.h: add BUS_CEC type Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 05/15] HID: add HDMI CEC specific keycodes Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 06/15] rc: Add HDMI CEC protocol handling Hans Verkuil
2015-10-06 18:05 ` Russell King - ARM Linux
2015-10-12 11:50 ` Hans Verkuil
2015-10-13 23:09 ` Russell King - ARM Linux
2015-10-14 7:12 ` Hans Verkuil
2015-10-15 7:31 ` Russell King - ARM Linux
2015-09-07 13:44 ` [PATCHv9 07/15] cec: add HDMI CEC framework Hans Verkuil
2015-10-06 17:06 ` Russell King - ARM Linux
2015-10-12 11:35 ` Hans Verkuil
2015-10-13 22:51 ` Russell King - ARM Linux
2015-10-14 6:29 ` Hans Verkuil
2015-10-15 17:34 ` Russell King - ARM Linux
2015-10-15 17:45 ` Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 08/15] cec.txt: add CEC framework documentation Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 09/15] DocBook/media: add CEC documentation Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 10/15] v4l2-subdev: add HDMI CEC ops Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 11/15] cec: adv7604: add cec support Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 12/15] cec: adv7842: " Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 13/15] cec: adv7511: " Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver Hans Verkuil
2015-10-05 22:32 ` Russell King - ARM Linux
2015-10-12 10:50 ` Hans Verkuil
2015-10-12 12:33 ` Kamil Debski
2015-10-12 12:39 ` Hans Verkuil
2015-10-12 12:44 ` Kamil Debski
2015-10-13 23:26 ` Russell King - ARM Linux
2015-10-05 23:11 ` Russell King - ARM Linux [this message]
2015-10-12 10:54 ` Hans Verkuil
2015-09-07 13:44 ` [PATCHv9 15/15] cobalt: add cec support Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005231109.GN21513@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=hansverk@cisco.com \
--cc=kamil@wypas.org \
--cc=kyungmin.park@samsung.com \
--cc=lars@opdenkamp.eu \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sean@mess.org \
--cc=thomas@tommie-lie.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).