linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Irina Tirdea <irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Bastien Nocera <hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Octavian Purdila
	<octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 0/9] Goodix touchscreen enhancements
Date: Fri, 9 Oct 2015 19:10:38 +0300	[thread overview]
Message-ID: <20151009191038.cb91cd52202f7c29e2fdbc24@gmail.com> (raw)
In-Reply-To: <1444314231-19206-1-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Thu,  8 Oct 2015 17:23:42 +0300
Irina Tirdea <irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

> Add several enhancements to the Goodix touchscreen driver.
> 
> The new functionality is only available for devices that
> declare named gpio pins for interrupt and reset in their
> ACPI/DT configuration.
> 

I tested this patchset on ARM tablet Wexler TAB7200 with GT911 touchscreen 
controller. All works fine, so you can add

Tested-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

>
> Thanks,
> Irina
> 
> Changes in v8:
>  - only allow new functionality for devices that declare named
> gpios (using _DSD properties in ACPI or named DT properties)
> 
> Changes in v7:
>  - add dmi quirk to skip gpio pins setup and functionality that
> depends on them for Onda v975w, WinBook TW100 and WinBook TW700.
>  - add support for named gpio pins
>  - rework the runtime pm patch to fix a couple of issues
>  - sort includes using inverse Xmas tree ordering
> 
> Changes in v6:
>  - skip runtime power manangent calls in open/close if the device
> ACPI/DT configuration does not declare interrupt and reset gpio pins.
>  - reset the device before starting i2c communication
>  - add Bastien's ack to the first 2 patches
> 
> Changes in v5:
>  - add some more style cleanup (reorder includes, use error instead
> of ret for return values)
>  - add runtime power management patch
> 
> Changes in v4:
>  - use dmi quirk to determine the order of irq and reset pins
>  - use actual config length depending on device
>  - add sysfs interface to dump config
>  - initialize esd timeout from ACPI/DT properly
> 
> Changes in v3:
>  - dropped the first 3 patches that got merged
>  - handle -EPROBE_DEFER and -ENOENT for gpio pins
>  - skip functionality depending on the gpio pins if the pins are not
> properly initialized from ACPI/DT (reset, write config, power management,
> ESD)
>  - dropped #ifdef CONFIG_PM_SLEEP and annotated with __maybe_unused instead
>  - use sysfs property to set ESD timeout instead of ACPI/DT property
>  - use request_firmware_nowait to read configuration firmware and use
> defaults if firmware is not found
>  - use ACPI IDs to determine the order of the GPIO pins in the ACPI tables
> (interrupt pin first or reset pin first)
> 
> Changes in v2:
>  - use request_firmware instead of ACPI/DT property for config
>  - dropped "input: goodix: add ACPI IDs for GT911 and GT9271" patch
>  - add ACPI DSDT excerpt in commit message where necessary
>  - add comments for suspend/resume sleep values
>  - dropped the checkpatch fixes that did not make sense
>  - added Bastien's ack to the first patch
> 
> Irina Tirdea (9):
>   Input: goodix - use actual config length for each device type
>   Input: goodix - reset device at init
>   Input: goodix - write configuration data to device
>   Input: goodix - add power management support
>   Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send
>   Input: goodix - add support for ESD
>   Input: goodix - add sysfs interface to dump config
>   Input: goodix - add runtime power management support
>   Input: goodix - sort includes using inverse Xmas tree order
> 
>  .../bindings/input/touchscreen/goodix.txt          |  11 +
>  drivers/input/touchscreen/goodix.c                 | 766 +++++++++++++++++++--
>  2 files changed, 732 insertions(+), 45 deletions(-)
> 
> -- 
> 1.9.1
> 


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-10-09 16:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 14:23 [PATCH v8 0/9] Goodix touchscreen enhancements Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 1/9] Input: goodix - use actual config length for each device type Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 2/9] Input: goodix - reset device at init Irina Tirdea
2015-10-09 14:22   ` Bastien Nocera
2015-10-10 23:35   ` kbuild test robot
     [not found] ` <1444314231-19206-1-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-08 14:23   ` [PATCH v8 3/9] Input: goodix - write configuration data to device Irina Tirdea
2015-10-09 16:10   ` Aleksei Mamlin [this message]
2015-10-08 14:23 ` [PATCH v8 4/9] Input: goodix - add power management support Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 5/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 6/9] Input: goodix - add support for ESD Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 7/9] Input: goodix - add sysfs interface to dump config Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 8/9] Input: goodix - add runtime power management support Irina Tirdea
2015-10-08 14:23 ` [PATCH v8 9/9] Input: goodix - sort includes using inverse Xmas tree order Irina Tirdea
2015-10-08 14:32 ` [PATCH v8 0/9] Goodix touchscreen enhancements Arnd Bergmann
2015-10-09 11:02   ` Tirdea, Irina
2015-10-09 11:54     ` Arnd Bergmann
2015-10-09 14:27 ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151009191038.cb91cd52202f7c29e2fdbc24@gmail.com \
    --to=mamlinav-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org \
    --cc=irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).