linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sylvain Rochet <sylvain.rochet@finsecur.com>
Cc: linux-input@vger.kernel.org, Daniel Mack <daniel@caiaq.de>,
	Johan Hovold <jhovold@gmail.com>
Subject: Re: [PATCH v5 0/2] input: rotary encoder: Add wake up support
Date: Tue, 13 Oct 2015 23:28:19 -0700	[thread overview]
Message-ID: <20151014062819.GD20406@dtor-ws> (raw)
In-Reply-To: <1444763620-14652-1-git-send-email-sylvain.rochet@finsecur.com>

On Tue, Oct 13, 2015 at 09:13:38PM +0200, Sylvain Rochet wrote:
> Changes since v4:
>   * As suggested by Johan, Reverted the 
>     device_set_wakeup_capable()/device_wakeup_enable() change,
>     stick to device_init_wakeup()
> 
> Changes since v3:
>   * Stick to the "wakeup-source" DT property, we are standardizing on it.
>   * Improved wake-up support: This driver is always supporting wake up
>     support, thus it is now calling device_set_wakeup_capable(dev, true)
>     followed by device_wakeup_enable(dev) if wake up is enabled at boot
>     time. This way the wakeup sysfs tree is always available to the user.
>     Only calling device_init_wakeup(dev, false) totally disable wake up  
>     support at boot tine with no way to enable wake up support furtherly,
>     which isn't nice.                                                    
> 
> Changes since v2:
>   * Using false instead of 0 on boolean
>   * Splitted DT documentation in a separate patch
> 
> Changes since v1:
>   * Using DT property wakeup-source instead of rotary-encoder,wakeup
>   * Renamed int wakeup to bool wakeup_source
>   * Patch cleanup (checkpatch.pl)
> 
> Sylvain Rochet (2):
>   Documentation: input: rotary encoder: Add wakeup-source property
>   input: rotary encoder: Add wake up support

Folded the 2 patches together and applied.

Thank you.

> 
>  .../devicetree/bindings/input/rotary-encoder.txt   |  1 +
>  Documentation/input/rotary-encoder.txt             |  1 +
>  drivers/input/misc/rotary_encoder.c                | 37 ++++++++++++++++++++++
>  include/linux/rotary_encoder.h                     |  1 +
>  4 files changed, 40 insertions(+)
> 
> -- 
> 2.5.1
> 

-- 
Dmitry

      parent reply	other threads:[~2015-10-14  6:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 19:13 [PATCH v5 0/2] input: rotary encoder: Add wake up support Sylvain Rochet
2015-10-13 19:13 ` [PATCH v5 1/2] Documentation: input: rotary encoder: Add wakeup-source property Sylvain Rochet
2015-10-13 19:13 ` [PATCH v5 2/2] input: rotary encoder: Add wake up support Sylvain Rochet
2015-10-14  6:28 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014062819.GD20406@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=daniel@caiaq.de \
    --cc=jhovold@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sylvain.rochet@finsecur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).