From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Roger Quadros <rogerq@ti.com>, Frodo Lai <frodo.lai@gmail.com>,
Jingoo Han <jg1.han@samsung.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: pixcir_i2c_ts: remove wakeirq related code from pixcir driver
Date: Tue, 13 Oct 2015 23:33:07 -0700 [thread overview]
Message-ID: <20151014063307.GE20406@dtor-ws> (raw)
In-Reply-To: <1444802036-18005-1-git-send-email-vigneshr@ti.com>
On Wed, Oct 14, 2015 at 11:23:56AM +0530, Vignesh R wrote:
> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
> interrupt in device tree") wakeirq is managed by i2c-core, so remove
> wakeirq related code from pixcir_i2c_ts driver.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 91621725bfb5..4b961ad9f0b5 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -377,8 +377,6 @@ static int __maybe_unused pixcir_i2c_ts_suspend(struct device *dev)
> goto unlock;
> }
> }
> -
> - enable_irq_wake(client->irq);
> } else if (input->users) {
> ret = pixcir_stop(ts);
> }
> @@ -399,7 +397,6 @@ static int __maybe_unused pixcir_i2c_ts_resume(struct device *dev)
> mutex_lock(&input->mutex);
>
> if (device_may_wakeup(&client->dev)) {
> - disable_irq_wake(client->irq);
>
> if (!input->users) {
> ret = pixcir_stop(ts);
> @@ -564,14 +561,6 @@ static int pixcir_i2c_ts_probe(struct i2c_client *client,
> return error;
>
> i2c_set_clientdata(client, tsdata);
> - device_init_wakeup(&client->dev, 1);
> -
> - return 0;
> -}
> -
> -static int pixcir_i2c_ts_remove(struct i2c_client *client)
> -{
> - device_init_wakeup(&client->dev, 0);
>
> return 0;
> }
> @@ -609,7 +598,6 @@ static struct i2c_driver pixcir_i2c_ts_driver = {
> .of_match_table = of_match_ptr(pixcir_of_match),
> },
> .probe = pixcir_i2c_ts_probe,
> - .remove = pixcir_i2c_ts_remove,
> .id_table = pixcir_i2c_ts_id,
> };
>
> --
> 2.6.1
>
--
Dmitry
prev parent reply other threads:[~2015-10-14 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 5:53 [PATCH] Input: pixcir_i2c_ts: remove wakeirq related code from pixcir driver Vignesh R
2015-10-14 6:33 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014063307.GE20406@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=frodo.lai@gmail.com \
--cc=jg1.han@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=rydberg@bitmath.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).