From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: pixcir_i2c_ts: remove wakeirq related code from pixcir driver Date: Tue, 13 Oct 2015 23:33:07 -0700 Message-ID: <20151014063307.GE20406@dtor-ws> References: <1444802036-18005-1-git-send-email-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f43.google.com ([209.85.220.43]:34945 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800AbbJNGdL (ORCPT ); Wed, 14 Oct 2015 02:33:11 -0400 Content-Disposition: inline In-Reply-To: <1444802036-18005-1-git-send-email-vigneshr@ti.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Vignesh R Cc: Roger Quadros , Frodo Lai , Jingoo Han , Henrik Rydberg , Krzysztof Kozlowski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Oct 14, 2015 at 11:23:56AM +0530, Vignesh R wrote: > With commit 3fffd1283927 ("i2c: allow specifying separate wakeup > interrupt in device tree") wakeirq is managed by i2c-core, so remove > wakeirq related code from pixcir_i2c_ts driver. > > Signed-off-by: Vignesh R Applied, thank you. > --- > drivers/input/touchscreen/pixcir_i2c_ts.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c > index 91621725bfb5..4b961ad9f0b5 100644 > --- a/drivers/input/touchscreen/pixcir_i2c_ts.c > +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c > @@ -377,8 +377,6 @@ static int __maybe_unused pixcir_i2c_ts_suspend(struct device *dev) > goto unlock; > } > } > - > - enable_irq_wake(client->irq); > } else if (input->users) { > ret = pixcir_stop(ts); > } > @@ -399,7 +397,6 @@ static int __maybe_unused pixcir_i2c_ts_resume(struct device *dev) > mutex_lock(&input->mutex); > > if (device_may_wakeup(&client->dev)) { > - disable_irq_wake(client->irq); > > if (!input->users) { > ret = pixcir_stop(ts); > @@ -564,14 +561,6 @@ static int pixcir_i2c_ts_probe(struct i2c_client *client, > return error; > > i2c_set_clientdata(client, tsdata); > - device_init_wakeup(&client->dev, 1); > - > - return 0; > -} > - > -static int pixcir_i2c_ts_remove(struct i2c_client *client) > -{ > - device_init_wakeup(&client->dev, 0); > > return 0; > } > @@ -609,7 +598,6 @@ static struct i2c_driver pixcir_i2c_ts_driver = { > .of_match_table = of_match_ptr(pixcir_of_match), > }, > .probe = pixcir_i2c_ts_probe, > - .remove = pixcir_i2c_ts_remove, > .id_table = pixcir_i2c_ts_id, > }; > > -- > 2.6.1 > -- Dmitry