From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dudley Du <dudl@cypress.com>
Cc: bleung@google.com, sudipm.mukherjee@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: cyapa: fix the copy paste error on electrodes_rx value
Date: Tue, 13 Oct 2015 23:34:20 -0700 [thread overview]
Message-ID: <20151014063420.GF20406@dtor-ws> (raw)
In-Reply-To: <1444630624-5127-1-git-send-email-dudl@cypress.com>
On Mon, Oct 12, 2015 at 02:17:04PM +0800, Dudley Du wrote:
> Fix the copy paste error on the electrodes_rx value set code which will
> cause the electrodes_rx value be always set to the value of electrodes_y.
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Reviewed-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Dudley Du <dudl@cypress.com>
Applied (with change to ternary ?: ), thank you.
> ---
> drivers/input/mouse/cyapa_gen6.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/mouse/cyapa_gen6.c b/drivers/input/mouse/cyapa_gen6.c
> index 5f19107..a5eb5ae 100644
> --- a/drivers/input/mouse/cyapa_gen6.c
> +++ b/drivers/input/mouse/cyapa_gen6.c
> @@ -241,14 +241,12 @@ static int cyapa_gen6_read_sys_info(struct cyapa *cyapa)
> memcpy(&cyapa->product_id[13], &resp_data[62], 2);
> cyapa->product_id[15] = '\0';
>
> + /* Get the number of Rx electrodes. */
> rotat_align = resp_data[68];
> - if (rotat_align) {
> + if (rotat_align)
> cyapa->electrodes_rx = cyapa->electrodes_y;
> - cyapa->electrodes_rx = cyapa->electrodes_y;
> - } else {
> + else
> cyapa->electrodes_rx = cyapa->electrodes_x;
> - cyapa->electrodes_rx = cyapa->electrodes_y;
> - }
> cyapa->aligned_electrodes_rx = (cyapa->electrodes_rx + 3) & ~3u;
>
> if (!cyapa->electrodes_x || !cyapa->electrodes_y ||
> --
> 1.9.1
>
>
> ---------------------------------------------------------------
> This message and any attachments may contain Cypress (or its
> subsidiaries) confidential information. If it has been received
> in error, please advise the sender and immediately delete this
> message.
> ---------------------------------------------------------------
>
--
Dmitry
prev parent reply other threads:[~2015-10-14 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 6:17 [PATCH] input: cyapa: fix the copy paste error on electrodes_rx value Dudley Du
2015-10-12 17:38 ` Benson Leung
2015-10-14 6:34 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014063420.GF20406@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@google.com \
--cc=dudl@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).