From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCHv9 06/15] rc: Add HDMI CEC protocol handling Date: Thu, 15 Oct 2015 08:31:08 +0100 Message-ID: <20151015073107.GT32532@n2100.arm.linux.org.uk> References: <345aeebe5561f8f6540f477ae160c5cbf1b0f6d5.1441633456.git.hansverk@cisco.com> <20151006180540.GR21513@n2100.arm.linux.org.uk> <561B9E97.4050909@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <561B9E97.4050909@xs4all.nl> Sender: linux-media-owner@vger.kernel.org To: Hans Verkuil , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, thomas@tommie-lie.de, sean@mess.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org, lars@opdenkamp.eu, kamil@wypas.org, Hans Verkuil List-Id: linux-input@vger.kernel.org On Mon, Oct 12, 2015 at 01:50:47PM +0200, Hans Verkuil wrote: > > Yet the rc-cec is a module in the filesystem, but it doesn't seem to > > be loaded automatically - even after the system has booted, the module > > hasn't been loaded. > > > > It looks like it _should_ be loaded, but this plainly isn't working: > > > > map = seek_rc_map(name); > > #ifdef MODULE This is the problem. MODULE is only set when _this_ file is built as a module. If this is built in, but your rc maps are modules, then they won't get loaded because this symbol will not be defined. It needs to be CONFIG_MODULES - and when it is, the rc-cec module is automatically loaded. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.