From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] xen: check return value of xenbus_printf Date: Thu, 15 Oct 2015 17:01:24 -0700 Message-ID: <20151016000124.GA1794@dtor-ws> References: <1444934412-18248-1-git-send-email-wuninsu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:34387 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbbJPAB2 (ORCPT ); Thu, 15 Oct 2015 20:01:28 -0400 Content-Disposition: inline In-Reply-To: <1444934412-18248-1-git-send-email-wuninsu@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Insu Yun Cc: david.vrabel@citrix.com, wei.liu2@citrix.com, julien.grall@citrix.com, stefano.stabellini@eu.citrix.com, huaixin.chx@alibaba-inc.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu Hi Insu, On Thu, Oct 15, 2015 at 06:40:12PM +0000, Insu Yun wrote: > Signed-off-by: Insu Yun It looks lik eyou lost your patch description when respinning. Thanks. > --- > drivers/input/misc/xen-kbdfront.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c > index 23d0549..9d465d7 100644 > --- a/drivers/input/misc/xen-kbdfront.c > +++ b/drivers/input/misc/xen-kbdfront.c > @@ -129,8 +129,14 @@ static int xenkbd_probe(struct xenbus_device *dev, > > if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-abs-pointer", "%d", &abs) < 0) > abs = 0; > - if (abs) > - xenbus_printf(XBT_NIL, dev->nodename, "request-abs-pointer", "1"); > + if (abs) { > + ret = xenbus_printf(XBT_NIL, dev->nodename, > + "request-abs-pointer", "1"); > + if (ret) { > + pr_warning("xenkbd: can't request abs-pointer"); > + abs = 0; > + } > + } > > /* keyboard */ > kbd = input_allocate_device(); > -- > 1.9.1 > -- Dmitry