linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: jaewon02.kim@samsung.com, k.kozlowski@samsung.com,
	dmurphy@ti.com, geert@linux-m68k.org,
	courtney.cavin@sonymobile.com, carlo@caione.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name
Date: Sun, 25 Oct 2015 13:49:23 -0700	[thread overview]
Message-ID: <20151025204923.GA23656@dtor-pixel> (raw)
In-Reply-To: <1445803567-8511-1-git-send-email-moritz.fischer@ettus.com>

Hi Moritz,

On Sun, Oct 25, 2015 at 01:06:06PM -0700, Moritz Fischer wrote:
> The produced module will be called e3x0-button, not
> e3x0_button.

This is not entirely correct. The file name is e3x0-button.ko, but the
module name is e3x0_button: when we construct KBUILD_MODNAME we
substitute commas and dashes for underscores - see scripts/Makefile.lib

> 
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  drivers/input/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 906dd1b..7ac277c7 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -101,7 +101,7 @@ config INPUT_E3X0_BUTTON
>  	  USRP E3x0 Button.
>  
>  	  To compile this driver as a module, choose M here: the
> -	  module will be called e3x0_button.
> +	  module will be called e3x0-button.
>  
>  config INPUT_PCSPKR
>  	tristate "PC Speaker support"
> -- 
> 2.6.2
> 

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2015-10-25 20:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 20:06 [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name Moritz Fischer
2015-10-25 20:06 ` [PATCH 2/2] input: misc: e3x0-button: Update Kconfig description Moritz Fischer
2015-10-25 20:56   ` Dmitry Torokhov
2015-10-25 20:49 ` Dmitry Torokhov [this message]
2015-10-26 18:04   ` [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151025204923.GA23656@dtor-pixel \
    --to=dmitry.torokhov@gmail.com \
    --cc=carlo@caione.org \
    --cc=courtney.cavin@sonymobile.com \
    --cc=dmurphy@ti.com \
    --cc=geert@linux-m68k.org \
    --cc=jaewon02.kim@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moritz.fischer@ettus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).