From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Michael Welling <mwelling@ieee.org>,
Arnd Bergmann <arnd@arndb.de>, kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Tony Lindgren <tony@atomide.com>,
Pavel Machek <pavel@ucw.cz>, Felipe Balbi <balbi@ti.com>,
Sebastian Reichel <sre@kernel.org>, Roger Quadros <rogerq@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004
Date: Fri, 30 Oct 2015 09:39:05 +0900 [thread overview]
Message-ID: <20151030003905.GL28319@sirena.org.uk> (raw)
In-Reply-To: <20151029222331.GA1419@localhost>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Thu, Oct 29, 2015 at 03:23:31PM -0700, Dmitry Torokhov wrote:
> However, you have regmap in the driver core already. Mark, is it
> possible to have regmap API also allow doing raw underlying protocol
> transfer so that consumers could issue command requests without needing
> to know if they need to do it over i2c or spi or whatever. Or we need a
> notion of command registers in regmap...
I don't think it's a good idea to break the encapsulation of the regmap
and export the raw I/O functionality directly, there seem to be more bad
ways of using that than good. The driver must at some point know what
bus it is dealing with and be able to manage this itself.
I don't know what "command registers" are.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-30 0:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 0:12 [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling
2015-10-29 7:25 ` kbuild test robot
2015-10-29 14:22 ` Michael Welling
2015-10-29 21:46 ` Arnd Bergmann
2015-10-29 21:53 ` Michael Welling
2015-10-29 22:23 ` Dmitry Torokhov
2015-10-30 0:39 ` Mark Brown [this message]
2015-10-30 1:01 ` Michael Welling
[not found] ` <20151030010151.GA4196-hEWAmvUofr51knWWc6b7UDvvZPQxeRhI@public.gmane.org>
2015-10-30 10:40 ` Arnd Bergmann
2015-10-30 1:45 ` Dmitry Torokhov
2015-10-30 2:08 ` Michael Welling
2015-10-30 2:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030003905.GL28319@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mwelling@ieee.org \
--cc=pavel@ucw.cz \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).