From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Welling <mwelling@ieee.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Tony Lindgren <tony@atomide.com>,
Pavel Machek <pavel@ucw.cz>, Felipe Balbi <balbi@ti.com>,
Sebastian Reichel <sre@kernel.org>, Roger Quadros <rogerq@ti.com>,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions
Date: Mon, 2 Nov 2015 17:49:46 -0800 [thread overview]
Message-ID: <20151103014946.GB32018@dtor-ws> (raw)
In-Reply-To: <1446252086-24334-2-git-send-email-mwelling@ieee.org>
On Fri, Oct 30, 2015 at 07:41:23PM -0500, Michael Welling wrote:
> This patch separates the SPI functionality from core functionality
> that overlaps with the tsc2004.
>
> Prepares kernel for new tsc2004 driver without much redundant code.
>
> Signed-off-by: Michael Welling <mwelling@ieee.org>
> ---
> drivers/input/touchscreen/Kconfig | 4 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/tsc2005.c | 709 +--------------------
> .../touchscreen/{tsc2005.c => tsc200x-core.c} | 226 ++-----
> drivers/input/touchscreen/tsc200x-core.h | 78 +++
> 5 files changed, 162 insertions(+), 856 deletions(-)
> copy drivers/input/touchscreen/{tsc2005.c => tsc200x-core.c} (72%)
> create mode 100644 drivers/input/touchscreen/tsc200x-core.h
This was giving me:
Kernel: arch/x86/boot/bzImage is ready (#1451)
MODPOST 1447 modules
ERROR: "tsc200x_regmap_config" [drivers/input/touchscreen/tsc2005.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
I'll fix it up locally by exporting the symbol.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-11-03 1:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 0:41 [PATCH v4 0/4] tsc2005 - Add support for tsc2004 Michael Welling
2015-10-31 0:41 ` [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions Michael Welling
2015-11-03 1:49 ` Dmitry Torokhov [this message]
2015-11-03 15:48 ` Michael Welling
2015-10-31 0:41 ` [PATCH 2/4] Input: tsc200x-core - Rename functions and variables Michael Welling
2015-10-31 0:41 ` [PATCH 3/4] Input: tsc2004 - Add support for tsc2004 Michael Welling
2015-10-31 0:41 ` [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Michael Welling
2015-11-02 15:19 ` Rob Herring
2015-11-02 20:50 ` Michael Welling
2015-11-03 7:21 ` Dmitry Torokhov
2015-11-03 15:31 ` Rob Herring
2015-11-03 15:41 ` Michael Welling
2015-11-03 22:59 ` Dmitry Torokhov
2015-11-03 23:11 ` Michael Welling
2015-11-03 23:30 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103014946.GB32018@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mwelling@ieee.org \
--cc=pavel@ucw.cz \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).