From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API change Date: Thu, 5 Nov 2015 10:23:10 -0800 Message-ID: <20151105182310.GB36023@dtor-ws> References: <14835877.IL6ArpWV8Q@wuerfel> <20151103234802.GC29032@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:36656 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965645AbbKESXO (ORCPT ); Thu, 5 Nov 2015 13:23:14 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Petri Gynther , Arnd Bergmann , linux-input , linux-kernel , linux-arm-kernel@lists.infradead.org On Wed, Nov 04, 2015 at 10:32:24AM +0100, Jiri Kosina wrote: > On Tue, 3 Nov 2015, Dmitry Torokhov wrote: > > > > > The input_configured callback was recently changed to return > > > > an 'int', but the newly added driver uses the old API: > > > > > > > > drivers/hid/hid-gfrm.c:151:22: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] > > > > > > > > This changes the driver like the other ones. > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > Acked-by: Petri Gynther > > > > Hmm, the question is how to merge this, given that one change is in > > Jiri's tree and another in mine... > > In this case probably the best course of action is you cherry-picking > b2c68a2f1bab from my tree into yours, and proceeding further. git can > handle doubled commits (that will end up in Linus' tree eventually) > easily. > > Another option would be to create a joint merge tree that'd contain both > branches merged together and proceed further from that, but I don't think > it's worth the hassle for simple case like this. > > Works for you? I went the cherry-pick route. Thanks. -- Dmitry