linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Linux Input <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Stephen Chandler Paul <cpaul@redhat.com>
Subject: Re: [PATCH 00/26] Consolidate patches and add support for new devices
Date: Mon, 9 Nov 2015 15:03:51 -0800	[thread overview]
Message-ID: <20151109230351.GB9155@dtor-ws> (raw)
In-Reply-To: <5641240C.5040603@synaptics.com>

On Mon, Nov 09, 2015 at 02:54:04PM -0800, Andrew Duggan wrote:
> Hi Linus,
> 
> Thanks for reviewing!
> 
> On 11/09/2015 04:49 AM, Linus Walleij wrote:
> >On Fri, Nov 6, 2015 at 12:34 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
> >
> >>NOTE: This patch set applies to synaptics-rmi4 branch in
> >>Dmitry Torokhov's input tree.
> >(...)
> >>This patchset applies cleanly to the synaptics-rmi4 branch, but does not
> >>successfully build because the synaptics-rmi4 branch is based on the 3.14
> >(...)
> >>I would suggest updating the synaptics-rmi4 branch to something
> >>more resent.
> >I suggest we stop seeing Dmitry's branch as "master" for RMI4 development.
> >Instead work on the v4.3-rc6-based branch you have at
> >https://github.com/aduggan/linux.git, and then (after the merge window)
> >rebase it to v4.4-rc1 and ask Dmitry to *drop* this old branch and pull in
> >your stuff instead, and then look at the end result of that.
> >
> >Who knows, maybe he thinks it's clean enough to go into v4.5.
> >Or for parts of it to go into v4.5.
> >
> >In any case, surely he's more helped by an up-to-date rebased branch
> >than having to rebase it himself too.
> >
> >>This patch set consolidates some outstanding patches and then builds on
> >>that to add support for new devices.
> >Unless Dmitry is extremely interested in the development history,
> >I suggest to squash the whole thing down to a few patches that
> >begins by adding the bus and infrastructure and then one function per
> >patch.
> 
> Ok, I'll rebase things. I realized when I was creating that patch
> set that at some point everything would have to be rebased. But, for
> the time being I was trying to maintain the history to avoid having
> to re-review the existing code. But, at this point it is probably
> better to review the driver as a whole. We will have my current
> branch and Dmitry's branch around if we end up needing the history.

OK, if you are rebasing/respoinning patches let's start with 4.3 - there
is nothing significantly new in input core in 4.4 and I'd rather start
at a stable point.

Thanks.

-- 
Dmitry

      reply	other threads:[~2015-11-09 23:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 23:34 [PATCH 00/26] Consolidate patches and add support for new devices Andrew Duggan
2015-11-05 23:34 ` [PATCH 01/26] Input: synaptics-rmi4 - embed the function modules in rmi_core Andrew Duggan
2015-11-05 23:34 ` [PATCH 02/26] Input: synaptics-rmi4 - add a common input device in rmi_driver Andrew Duggan
2015-11-05 23:34 ` [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed Andrew Duggan
2015-11-05 23:34 ` [PATCH 04/26] Input: synaptics-rmi4 - prevent oopses when irq arrives while the device is not bound Andrew Duggan
2015-11-09 12:49 ` [PATCH 00/26] Consolidate patches and add support for new devices Linus Walleij
2015-11-09 22:54   ` Andrew Duggan
2015-11-09 23:03     ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151109230351.GB9155@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=cheiny@synaptics.com \
    --cc=cpaul@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).