linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Stephen Chandler Paul <cpaul@redhat.com>
Subject: Re: [PATCH 20/26] Input: synaptics-rmi4: Create common functions for 2D sensors
Date: Mon, 9 Nov 2015 15:35:25 -0800	[thread overview]
Message-ID: <20151109233525.GH9155@dtor-ws> (raw)
In-Reply-To: <1446766925-31123-1-git-send-email-aduggan@synaptics.com>

On Thu, Nov 05, 2015 at 03:42:05PM -0800, Andrew Duggan wrote:
> +config RMI4_2D_SENSOR
> +	bool "RMI4 2D Sensors"

Should this be a hidden option that is selected by RMI4_F11 and RMI4_F12
instead?

Thanks.

> +	depends on RMI4_CORE
> +	default y if RMI4_CORE
> +	help
> +	  Say Y here if you want to add support for 2D Sensors.
> +
> +	  Provides core functionality for 2D multifinger pointing for
> +	  touchscreens and touchpads using RMI4 functions 11 and 12. This
> +	  feature is needed is the device contains either F11 or F12.
> +
>  config RMI4_F11
>  	bool "RMI4 Function 11 (2D pointing)"


-- 
Dmitry

      parent reply	other threads:[~2015-11-09 23:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 23:42 [PATCH 20/26] Input: synaptics-rmi4: Create common functions for 2D sensors Andrew Duggan
2015-11-09 13:25 ` Linus Walleij
2015-11-09 23:35 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151109233525.GH9155@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=cheiny@synaptics.com \
    --cc=cpaul@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).