From: Juergen Borleis <jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Eric Bc3a9nard <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver
Date: Mon, 23 Nov 2015 09:21:02 +0100 [thread overview]
Message-ID: <201511230921.02588.jbe@pengutronix.de> (raw)
In-Reply-To: <5650AE5A.5010506-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Hi Jonathan,
On Saturday 21 November 2015 18:48:10 Jonathan Cameron wrote:
> [...]
> Another personal preference. I'd not bother wrapping these single line
> calls up but rather just make them inline. They don't in of
> themselves add much to my mind. Still this one is very much up to you
> as far as I'm concerned.
A matter of taste. Programming bits is more or less hard to understand even if
we use macros with useful names. So it is me to prefer self explaining
functions by no cost of code because the compiler will optimise it away.
Regards,
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-23 8:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 12:01 [PATCH v8 0/8] imx25 adc and touchscreen driver Markus Pargmann
2015-11-16 12:01 ` [PATCH v8 1/8] ARM: dt: Binding documentation for imx25 ADC/TSC Markus Pargmann
[not found] ` <1447675269-8831-2-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-16 14:01 ` Rob Herring
2015-11-23 14:59 ` Lee Jones
2015-11-24 10:44 ` Markus Pargmann
2015-11-16 12:01 ` [PATCH v8 2/8] ARM: dt: Binding documentation for imx25 GCQ Markus Pargmann
2015-11-16 15:12 ` Rob Herring
2015-11-17 7:46 ` Markus Pargmann
2015-11-16 12:01 ` [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller Markus Pargmann
2015-11-16 14:16 ` Rob Herring
2015-11-17 8:54 ` Markus Pargmann
2015-11-17 18:21 ` Dmitry Torokhov
2015-11-16 12:01 ` [PATCH v8 4/8] mfd: fsl imx25 Touchscreen ADC driver Markus Pargmann
2015-11-21 17:02 ` Jonathan Cameron
[not found] ` <5650A3AA.5080705-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-21 17:26 ` Jonathan Cameron
2015-11-23 9:17 ` Markus Pargmann
[not found] ` <1447675269-8831-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-16 12:01 ` [PATCH v8 5/8] iio: adc: fsl,imx25-gcq driver Markus Pargmann
2015-11-16 12:01 ` [PATCH v8 6/8] input: touchscreen: imx25 tcq driver Markus Pargmann
[not found] ` <1447675269-8831-7-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-17 18:17 ` Dmitry Torokhov
2015-11-20 13:33 ` Markus Pargmann
2015-11-21 17:48 ` Jonathan Cameron
2015-11-21 17:50 ` Jonathan Cameron
[not found] ` <5650AE5A.5010506-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-23 8:21 ` Juergen Borleis [this message]
2015-11-23 13:43 ` Markus Pargmann
2015-11-16 12:01 ` [PATCH v8 8/8] ARM: imx_v4_v5_defconfig: Add I.MX25 Touchscreen controller and ADC support Markus Pargmann
2015-11-16 12:01 ` [PATCH v8 7/8] ARM: dts: imx25: Add TSC " Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511230921.02588.jbe@pengutronix.de \
--to=jbe-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).