From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Borleis Subject: Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver Date: Mon, 23 Nov 2015 09:21:02 +0100 Message-ID: <201511230921.02588.jbe@pengutronix.de> References: <1447675269-8831-1-git-send-email-mpa@pengutronix.de> <1447675269-8831-7-git-send-email-mpa@pengutronix.de> <5650AE5A.5010506@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5650AE5A.5010506-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Content-Disposition: inline Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org Cc: Jonathan Cameron , Markus Pargmann , Shawn Guo , Dmitry Torokhov , Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eric Bc3a9nard , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hartmut Knaack , Denis Carikli , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fabio Estevam , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-input@vger.kernel.org Hi Jonathan, On Saturday 21 November 2015 18:48:10 Jonathan Cameron wrote: > [...] > Another personal preference. I'd not bother wrapping these single lin= e > calls up but rather just make them inline. They don't in of > themselves add much to my mind. Still this one is very much up to yo= u > as far as I'm concerned. A matter of taste. Programming bits is more or less hard to understand = even if=20 we use macros with useful names. So it is me to prefer self explaining=20 functions by no cost of code because the compiler will optimise it away= =2E Regards, Juergen --=20 Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0| Juergen Borleis =A0 =A0 =A0 =A0 =A0 =A0 | Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| htt= p://www.pengutronix.de/ =A0| -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html