From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: psmouse - rename ps2pp_init() to ps2pp_detect()
Date: Wed, 2 Dec 2015 11:26:18 -0800 [thread overview]
Message-ID: <20151202192618.GA24386@dtor-ws> (raw)
In-Reply-To: <20151202192044.GA12580@dtor-ws>
On Wed, Dec 02, 2015 at 11:20:44AM -0800, Dmitry Torokhov wrote:
> This makes Logitech PS2++ protocol implementation consistent with
> the naming in other protocols.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Well, if I did not forget to add drivers/input/mouse/logips2pp.c that
woudl be better...
> ---
> drivers/input/mouse/logips2pp.h | 4 ++--
> drivers/input/mouse/psmouse-base.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/logips2pp.h b/drivers/input/mouse/logips2pp.h
> index 0c186f0..075fd32 100644
> --- a/drivers/input/mouse/logips2pp.h
> +++ b/drivers/input/mouse/logips2pp.h
> @@ -12,9 +12,9 @@
> #define _LOGIPS2PP_H
>
> #ifdef CONFIG_MOUSE_PS2_LOGIPS2PP
> -int ps2pp_init(struct psmouse *psmouse, bool set_properties);
> +int ps2pp_detect(struct psmouse *psmouse, bool set_properties);
> #else
> -inline int ps2pp_init(struct psmouse *psmouse, bool set_properties)
> +static inline int ps2pp_detect(struct psmouse *psmouse, bool set_properties)
> {
> return -ENOSYS;
> }
> diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
> index e909c6e..90d9218 100644
> --- a/drivers/input/mouse/psmouse-base.c
> +++ b/drivers/input/mouse/psmouse-base.c
> @@ -699,7 +699,7 @@ static const struct psmouse_protocol psmouse_protocols[] = {
> .type = PSMOUSE_PS2PP,
> .name = "PS2++",
> .alias = "logitech",
> - .detect = ps2pp_init,
> + .detect = ps2pp_detect,
> },
> #endif
> {
> --
> 2.6.0.rc2.230.g3dd15c0
>
>
> --
> Dmitry
--
Dmitry
prev parent reply other threads:[~2015-12-02 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 19:20 [PATCH] Input: psmouse - rename ps2pp_init() to ps2pp_detect() Dmitry Torokhov
2015-12-02 19:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202192618.GA24386@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).