From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [patch] Input: omap-keypad: set tasklet data earlier Date: Thu, 7 Jan 2016 09:55:32 -0800 Message-ID: <20160107175532.GA12332@dtor-ws> References: <20160107093648.GC27186@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160107093648.GC27186@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Komal Shah , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-input@vger.kernel.org On Thu, Jan 07, 2016 at 12:36:48PM +0300, Dan Carpenter wrote: > It feels like we should set the tasklet data before enabling it. > > Signed-off-by: Dan Carpenter Applied, thank you. > > diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c > index 7502e46..75ad666 100644 > --- a/drivers/input/keyboard/omap-keypad.c > +++ b/drivers/input/keyboard/omap-keypad.c > @@ -292,8 +292,8 @@ static int omap_kp_probe(struct platform_device *pdev) > setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp); > > /* get the irq and init timer*/ > - tasklet_enable(&kp_tasklet); > kp_tasklet.data = (unsigned long) omap_kp; > + tasklet_enable(&kp_tasklet); > > ret = device_create_file(&pdev->dev, &dev_attr_enable); > if (ret < 0) -- Dmitry