From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] OMAP: Add keypad driver
Date: Thu, 7 Jan 2016 12:13:17 -0800
Message-ID: <20160107201316.GF12600@atomide.com>
References: <20160107093751.GD27186@mwanda>
 <CAKdAkRSic46XAhuXO6fijBTWMaRJPqRNPx6MwTv=Pgoo6JL=hQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-input-owner@vger.kernel.org>
Received: from muru.com ([72.249.23.125]:53882 "EHLO muru.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752189AbcAGUNV (ORCPT <rfc822;linux-input@vger.kernel.org>);
	Thu, 7 Jan 2016 15:13:21 -0500
Content-Disposition: inline
In-Reply-To: <CAKdAkRSic46XAhuXO6fijBTWMaRJPqRNPx6MwTv=Pgoo6JL=hQ@mail.gmail.com>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, Komal Shah <komal_shah802003@yahoo.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>, Aaro Koskinen <aaro.koskinen@nokia.com>, linux-omap@vger.kernel.org

Hi,

* Dmitry Torokhov <dmitry.torokhov@gmail.com> [160107 10:54]:
> On Thu, Jan 7, 2016 at 1:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > Hello file (standard input) matches,
> >
> > The patch ad4e09b16ad3: "[PATCH] OMAP: Add keypad driver", leads to the
> > following static checker warning:
> >
> >         drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet()
> >         warn: 'keycodes[]' is never negative.
> 
> It looks like you are not resolving commits correctly, the original
> submission did not have this issue.
> 
> >
> > drivers/input/keyboard/omap-keypad.c
...
> >    152  #ifdef NEW_BOARD_LEARNING_MODE
> >    153                          printk(KERN_INFO "omap-keypad: key %d-%d %s\n", col,
> >    154                                 row, (new_state[col] & (1 << row)) ?
> >    155                                 "pressed" : "released");
> >    156  #else
> >    157                          key = keycodes[MATRIX_SCAN_CODE(row, col, row_shift)];
> >    158                          if (key < 0) {
> >                                     ^^^^^^^
> > Never true.  Not sure what was intended.
> 
> It looks like this check was broken by
> da1f026b532ce944d74461497dc6d8c16456466e (Keyboard: omap-keypad: use
> matrix_keypad.h). Previously the driver would expect a list of known
> keys and would scan it and return -1 if key was not found. Now we have
> 2 options:
> 
> 1. Simply remove the check
> 2. Change the condition to "if (key == KEY_RESERVED)"
> 
> I do not really have preference. Tony?

Sounds like the check is not needed if it has not been used for
past five years, so my preference is option #1 then.

Regards,

Tony