From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP: Add keypad driver Date: Thu, 7 Jan 2016 16:13:45 -0800 Message-ID: <20160108001344.GR12777@atomide.com> References: <20160107093751.GD27186@mwanda> <20160107201316.GF12600@atomide.com> <20160107232228.GA20533@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:53919 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753199AbcAHANt (ORCPT ); Thu, 7 Jan 2016 19:13:49 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Koskinen, Aaro (Nokia - FI/Espoo)" Cc: EXT Dmitry Torokhov , Dan Carpenter , Komal Shah , "linux-input@vger.kernel.org" , Janusz Krzysztofik , "linux-omap@vger.kernel.org" * Koskinen, Aaro (Nokia - FI/Espoo) [160107 16:08]: > Hi, > > > From: Dmitry Torokhov > > > > Commit da1f026b532ce944d74461497dc6d8c16456466e ("Keyboard: omap-keypad: > > use matrix_keypad.h") switched the driver to use matrix keypad > > infrastructure, which made array of keycodes to be unsigned short, and > > caused the test for negativity never trigger. This leads to the following > > static checker warning: > > > > drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet() > > warn: 'keycodes[]' is never negative. > > > > Given that we did not care about this check for a few years already let's > > simply remove it. > > > > Reported-by: Dan Carpenter > > Signed-off-by: Dmitry Torokhov > > Acked-by: Aaro Koskinen Heh sorry I mis-corrected your email in my reply, old habit you know :) Tony