From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v10 4/8] mfd: fsl imx25 Touchscreen ADC driver Date: Mon, 11 Jan 2016 06:54:41 +0000 Message-ID: <20160111065441.GW3331@x1> References: <1450101234-2191-1-git-send-email-mpa@pengutronix.de> <1450101234-2191-5-git-send-email-mpa@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1450101234-2191-5-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Markus Pargmann Cc: Shawn Guo , Dmitry Torokhov , Jonathan Cameron , Denis Carikli , Eric =?iso-8859-1?Q?B=E9nard?= , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Hartmut Knaack , Fabio Estevam , Juergen Borleis List-Id: linux-input@vger.kernel.org On Mon, 14 Dec 2015, Markus Pargmann wrote: > This is the core driver for imx25 touchscreen/adc driver. The module > has one shared ADC and two different conversion queues which use the > ADC. The two queues are identical. Both can be used for general purpo= se > ADC but one is meant to be used for touchscreens. >=20 > This driver is the core which manages the central components and > registers of the TSC/ADC unit. It manages the IRQs and forwards them = to > the correct components. >=20 > Signed-off-by: Markus Pargmann > Signed-off-by: Denis Carikli >=20 > [ensure correct ADC clock depending on the IPG clock] > Signed-off-by: Juergen Borleis > Acked-by: Jonathan Cameron > --- >=20 > Notes: > Changes in v7: > - Cleanup bit defines in header files to be more readable > - Fix irq check to return with an error for irq <=3D 0 > - Add COMPILE_TEST in Kconfig file > =20 > Changes in v5: > - Remove ifdef CONFIG_OF as this driver is only for DT usage > - Remove module owner > - Add Kconfig dependencies ARCH_MX25 and OF >=20 > drivers/mfd/Kconfig | 9 ++ > drivers/mfd/Makefile | 2 + > drivers/mfd/fsl-imx25-tsadc.c | 203 ++++++++++++++++++++++++++++++= ++++++++++ > include/linux/mfd/imx25-tsadc.h | 140 +++++++++++++++++++++++++++ > 4 files changed, 354 insertions(+) > create mode 100644 drivers/mfd/fsl-imx25-tsadc.c > create mode 100644 include/linux/mfd/imx25-tsadc.h =46or my own reference: Acked-by: Lee Jones I will apply this and sent out pull-requests to the relevant maintainers once -rc1 is out. [...] --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog