From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Ping Cheng <pinglinux@gmail.com>,
Jason Gerecke <killertofu@gmail.com>
Subject: Re: [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE
Date: Mon, 11 Jan 2016 00:12:33 -0800 [thread overview]
Message-ID: <20160111081233.GA27512@dtor-ws> (raw)
In-Reply-To: <20160111035151.GA24743@jelly.redhat.com>
On Mon, Jan 11, 2016 at 01:51:51PM +1000, Peter Hutterer wrote:
> As of e0361b70175f0cd6199dd9ed6679632de73973d4
> Input: wacom_w8001 - split the touch and pen devices into two devices
> the touch events aren't multiplexed over the same device anymore, the use of
> ABS_MT_TOOL_TYPE is superfluous. And even before then it only ever sent
> MT_TOOL_TYPE_FINGER anyway.
>
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Applied, thank you.
> ---
> drivers/input/touchscreen/wacom_w8001.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c
> index fe983e7..bab3c6a 100644
> --- a/drivers/input/touchscreen/wacom_w8001.c
> +++ b/drivers/input/touchscreen/wacom_w8001.c
> @@ -155,7 +155,6 @@ static void parse_multi_touch(struct w8001 *w8001)
> bool touch = data[0] & (1 << i);
>
> input_mt_slot(dev, i);
> - input_mt_report_slot_state(dev, MT_TOOL_FINGER, touch);
> if (touch) {
> x = (data[6 * i + 1] << 7) | data[6 * i + 2];
> y = (data[6 * i + 3] << 7) | data[6 * i + 4];
> @@ -514,8 +513,6 @@ static int w8001_setup_touch(struct w8001 *w8001, char *basename,
> 0, touch.x, 0, 0);
> input_set_abs_params(dev, ABS_MT_POSITION_Y,
> 0, touch.y, 0, 0);
> - input_set_abs_params(dev, ABS_MT_TOOL_TYPE,
> - 0, MT_TOOL_MAX, 0, 0);
>
> strlcat(basename, " 2FG", basename_sz);
> if (w8001->max_pen_x && w8001->max_pen_y)
> --
> 2.5.0
>
--
Dmitry
next prev parent reply other threads:[~2016-01-11 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 3:51 [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE Peter Hutterer
2016-01-11 8:12 ` Dmitry Torokhov [this message]
2016-07-14 0:09 ` Dmitry Torokhov
2016-07-14 0:22 ` Ping Cheng
2016-07-14 5:57 ` Peter Hutterer
2016-07-14 16:42 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111081233.GA27512@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).