From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE Date: Mon, 11 Jan 2016 00:12:33 -0800 Message-ID: <20160111081233.GA27512@dtor-ws> References: <20160111035151.GA24743@jelly.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:36332 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758488AbcAKIMg (ORCPT ); Mon, 11 Jan 2016 03:12:36 -0500 Received: by mail-pf0-f193.google.com with SMTP id n128so3331799pfn.3 for ; Mon, 11 Jan 2016 00:12:36 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160111035151.GA24743@jelly.redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Peter Hutterer Cc: linux-input@vger.kernel.org, Benjamin Tissoires , Ping Cheng , Jason Gerecke On Mon, Jan 11, 2016 at 01:51:51PM +1000, Peter Hutterer wrote: > As of e0361b70175f0cd6199dd9ed6679632de73973d4 > Input: wacom_w8001 - split the touch and pen devices into two devices > the touch events aren't multiplexed over the same device anymore, the use of > ABS_MT_TOOL_TYPE is superfluous. And even before then it only ever sent > MT_TOOL_TYPE_FINGER anyway. > > Signed-off-by: Peter Hutterer Applied, thank you. > --- > drivers/input/touchscreen/wacom_w8001.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c > index fe983e7..bab3c6a 100644 > --- a/drivers/input/touchscreen/wacom_w8001.c > +++ b/drivers/input/touchscreen/wacom_w8001.c > @@ -155,7 +155,6 @@ static void parse_multi_touch(struct w8001 *w8001) > bool touch = data[0] & (1 << i); > > input_mt_slot(dev, i); > - input_mt_report_slot_state(dev, MT_TOOL_FINGER, touch); > if (touch) { > x = (data[6 * i + 1] << 7) | data[6 * i + 2]; > y = (data[6 * i + 3] << 7) | data[6 * i + 4]; > @@ -514,8 +513,6 @@ static int w8001_setup_touch(struct w8001 *w8001, char *basename, > 0, touch.x, 0, 0); > input_set_abs_params(dev, ABS_MT_POSITION_Y, > 0, touch.y, 0, 0); > - input_set_abs_params(dev, ABS_MT_TOOL_TYPE, > - 0, MT_TOOL_MAX, 0, 0); > > strlcat(basename, " 2FG", basename_sz); > if (w8001->max_pen_x && w8001->max_pen_y) > -- > 2.5.0 > -- Dmitry