From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() Date: Sat, 16 Jan 2016 10:36:36 -0800 Message-ID: <20160116183636.GD9203@dtor-ws> References: <1452880875-4148-1-git-send-email-grygorii.strashko@ti.com> <9158432.BHbKetFqR6@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f180.google.com ([209.85.192.180]:34638 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbcAPSgk (ORCPT ); Sat, 16 Jan 2016 13:36:40 -0500 Content-Disposition: inline In-Reply-To: <9158432.BHbKetFqR6@vostro.rjw.lan> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Rafael J. Wysocki" Cc: Grygorii Strashko , linux-input@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, lkp@01.org On Fri, Jan 15, 2016 at 09:53:14PM +0100, Rafael J. Wysocki wrote: > On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote: > > Now serio_find_driver() will print warnings in case device_attach() > > returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because: > > - DD core can report the same if required > > - since commit 013c074f8642 ("PM / sleep: prohibit devices probing > > during suspend/hibernation") the devices probing is prohibited during > > System suspend and deferred device will be carefully reprobed once > > Resume is finished. > > > > Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver(). > > > > Cc: Dmitry Torokhov > > Cc: Rafael J. Wysocki > > Signed-off-by: Grygorii Strashko > > Acked-by: Rafael J. Wysocki Applied, thank you. > > > --- > > drivers/input/serio/serio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c > > index 8f82897..1ca7f55 100644 > > --- a/drivers/input/serio/serio.c > > +++ b/drivers/input/serio/serio.c > > @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio) > > int error; > > > > error = device_attach(&serio->dev); > > - if (error < 0) > > + if (error < 0 && error != -EPROBE_DEFER) > > dev_warn(&serio->dev, > > "device_attach() failed for %s (%s), error: %d\n", > > serio->phys, serio->name, error); > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- Dmitry