* [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver()
@ 2016-01-15 18:01 Grygorii Strashko
2016-01-15 20:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Grygorii Strashko @ 2016-01-15 18:01 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, nsekhar, linux-kernel, lkp, Grygorii Strashko,
Rafael J . Wysocki
Now serio_find_driver() will print warnings in case device_attach()
returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
- DD core can report the same if required
- since commit 013c074f8642 ("PM / sleep: prohibit devices probing
during suspend/hibernation") the devices probing is prohibited during
System suspend and deferred device will be carefully reprobed once
Resume is finished.
Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/input/serio/serio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index 8f82897..1ca7f55 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
int error;
error = device_attach(&serio->dev);
- if (error < 0)
+ if (error < 0 && error != -EPROBE_DEFER)
dev_warn(&serio->dev,
"device_attach() failed for %s (%s), error: %d\n",
serio->phys, serio->name, error);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver()
2016-01-15 18:01 [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() Grygorii Strashko
@ 2016-01-15 20:53 ` Rafael J. Wysocki
2016-01-16 18:36 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-01-15 20:53 UTC (permalink / raw)
To: Grygorii Strashko
Cc: Dmitry Torokhov, linux-input, nsekhar, linux-kernel, lkp
On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote:
> Now serio_find_driver() will print warnings in case device_attach()
> returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
> - DD core can report the same if required
> - since commit 013c074f8642 ("PM / sleep: prohibit devices probing
> during suspend/hibernation") the devices probing is prohibited during
> System suspend and deferred device will be carefully reprobed once
> Resume is finished.
>
> Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/input/serio/serio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> index 8f82897..1ca7f55 100644
> --- a/drivers/input/serio/serio.c
> +++ b/drivers/input/serio/serio.c
> @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
> int error;
>
> error = device_attach(&serio->dev);
> - if (error < 0)
> + if (error < 0 && error != -EPROBE_DEFER)
> dev_warn(&serio->dev,
> "device_attach() failed for %s (%s), error: %d\n",
> serio->phys, serio->name, error);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver()
2016-01-15 20:53 ` Rafael J. Wysocki
@ 2016-01-16 18:36 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2016-01-16 18:36 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Grygorii Strashko, linux-input, nsekhar, linux-kernel, lkp
On Fri, Jan 15, 2016 at 09:53:14PM +0100, Rafael J. Wysocki wrote:
> On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote:
> > Now serio_find_driver() will print warnings in case device_attach()
> > returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
> > - DD core can report the same if required
> > - since commit 013c074f8642 ("PM / sleep: prohibit devices probing
> > during suspend/hibernation") the devices probing is prohibited during
> > System suspend and deferred device will be carefully reprobed once
> > Resume is finished.
> >
> > Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Applied, thank you.
>
> > ---
> > drivers/input/serio/serio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> > index 8f82897..1ca7f55 100644
> > --- a/drivers/input/serio/serio.c
> > +++ b/drivers/input/serio/serio.c
> > @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
> > int error;
> >
> > error = device_attach(&serio->dev);
> > - if (error < 0)
> > + if (error < 0 && error != -EPROBE_DEFER)
> > dev_warn(&serio->dev,
> > "device_attach() failed for %s (%s), error: %d\n",
> > serio->phys, serio->name, error);
> >
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-16 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15 18:01 [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() Grygorii Strashko
2016-01-15 20:53 ` Rafael J. Wysocki
2016-01-16 18:36 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).