* Re: [PATCH] hid:Add warning message if sysfs group is not created for passed kobject in the function, mt_probe
[not found] <1454601160-21966-1-git-send-email-xerofoify@gmail.com>
@ 2016-02-05 7:48 ` Benjamin Tissoires
2016-02-05 13:37 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tissoires @ 2016-02-05 7:48 UTC (permalink / raw)
To: Nicholas Krause; +Cc: jikos, linux-input, linux-kernel
Hi Nick,
On Feb 04 2016 or thereabouts, Nicholas Krause wrote:
> This adds a warning message stating that the sysfs group was not
> able to be created for the passed hid_device structure pointer
> with dev_warn.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/hid/hid-multitouch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 296d499..b2b2451 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1133,6 +1133,8 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
> return ret;
>
> ret = sysfs_create_group(&hdev->dev.kobj, &mt_attribute_group);
> + if (ret)
> + dev_warn(&hdev->dev, "Cannot allocate sysfs group for %s\n", hdev->name);
Just nitpicking here. Checkpatch.pl complains about a line over 80
characters here. Could you (or maybe just Jiri) fix that?
Otherwise:
Reviewed-by: Benjamin Tissoires <benajmin.tissoires@redhat.com>
Cheers,
Benjamin
>
> mt_set_maxcontacts(hdev);
> mt_set_input_mode(hdev);
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hid:Add warning message if sysfs group is not created for passed kobject in the function, mt_probe
2016-02-05 7:48 ` [PATCH] hid:Add warning message if sysfs group is not created for passed kobject in the function, mt_probe Benjamin Tissoires
@ 2016-02-05 13:37 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2016-02-05 13:37 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Nicholas Krause, linux-input, linux-kernel
On Fri, 5 Feb 2016, Benjamin Tissoires wrote:
> > This adds a warning message stating that the sysfs group was not
> > able to be created for the passed hid_device structure pointer
> > with dev_warn.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > ---
> > drivers/hid/hid-multitouch.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> > index 296d499..b2b2451 100644
> > --- a/drivers/hid/hid-multitouch.c
> > +++ b/drivers/hid/hid-multitouch.c
> > @@ -1133,6 +1133,8 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
> > return ret;
> >
> > ret = sysfs_create_group(&hdev->dev.kobj, &mt_attribute_group);
> > + if (ret)
> > + dev_warn(&hdev->dev, "Cannot allocate sysfs group for %s\n", hdev->name);
>
> Just nitpicking here. Checkpatch.pl complains about a line over 80
> characters here. Could you (or maybe just Jiri) fix that?
>
> Otherwise:
> Reviewed-by: Benjamin Tissoires <benajmin.tissoires@redhat.com>
Thanks. I've reformatted the source (and also changelog a bit) and
applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-05 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1454601160-21966-1-git-send-email-xerofoify@gmail.com>
2016-02-05 7:48 ` [PATCH] hid:Add warning message if sysfs group is not created for passed kobject in the function, mt_probe Benjamin Tissoires
2016-02-05 13:37 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).