* [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h>
@ 2016-02-07 14:18 Geert Uytterhoeven
2016-02-07 14:18 ` [PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB Geert Uytterhoeven
2016-02-09 18:33 ` [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Dmitry Torokhov
0 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-02-07 14:18 UTC (permalink / raw)
To: Dmitry Torokhov, Bastien Nocera, Sanchayan Maity
Cc: linux-input, linux-gpio, Geert Uytterhoeven
drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’:
drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Seen with "[PATCH 2/2] Input: Allow compile test of Goodix and Colibri
VF50 if !GPIOLIB" on m68k/allmodconfig
drivers/input/touchscreen/colibri-vf50-ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
index 5d4903a402cc6a5f..69828d015d45ffa4 100644
--- a/drivers/input/touchscreen/colibri-vf50-ts.c
+++ b/drivers/input/touchscreen/colibri-vf50-ts.c
@@ -21,6 +21,7 @@
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB
2016-02-07 14:18 [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Geert Uytterhoeven
@ 2016-02-07 14:18 ` Geert Uytterhoeven
2016-02-09 18:34 ` Dmitry Torokhov
2016-02-09 18:33 ` [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Dmitry Torokhov
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-02-07 14:18 UTC (permalink / raw)
To: Dmitry Torokhov, Bastien Nocera, Sanchayan Maity
Cc: linux-input, linux-gpio, Geert Uytterhoeven
The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
functionality only, can still be compiled if GPIOLIB is not enabled.
If COMPILE_TEST is enabled, relax the dependency on GPIOLIB for the
recently introduced or relaxed symbols TOUCHSCREEN_GOODIX and
TOUCHSCREEN_COLIBRI_VF50.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/input/touchscreen/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 66c62641b59a31cf..fba4d5665857221b 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -334,7 +334,7 @@ config TOUCHSCREEN_FUJITSU
config TOUCHSCREEN_GOODIX
tristate "Goodix I2C touchscreen"
depends on I2C
- depends on GPIOLIB
+ depends on GPIOLIB || COMPILE_TEST
help
Say Y here if you have the Goodix touchscreen (such as one
installed in Onda v975w tablets) connected to your
@@ -1112,7 +1112,8 @@ config TOUCHSCREEN_ZFORCE
config TOUCHSCREEN_COLIBRI_VF50
tristate "Toradex Colibri on board touchscreen driver"
- depends on GPIOLIB && IIO && VF610_ADC
+ depends on IIO && VF610_ADC
+ depends on GPIOLIB || COMPILE_TEST
help
Say Y here if you have a Colibri VF50 and plan to use
the on-board provided 4-wire touchscreen driver.
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB
2016-02-07 14:18 ` [PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB Geert Uytterhoeven
@ 2016-02-09 18:34 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2016-02-09 18:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bastien Nocera, Sanchayan Maity, linux-input, linux-gpio
On Sun, Feb 07, 2016 at 03:18:07PM +0100, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> If COMPILE_TEST is enabled, relax the dependency on GPIOLIB for the
> recently introduced or relaxed symbols TOUCHSCREEN_GOODIX and
> TOUCHSCREEN_COLIBRI_VF50.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 66c62641b59a31cf..fba4d5665857221b 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -334,7 +334,7 @@ config TOUCHSCREEN_FUJITSU
> config TOUCHSCREEN_GOODIX
> tristate "Goodix I2C touchscreen"
> depends on I2C
> - depends on GPIOLIB
> + depends on GPIOLIB || COMPILE_TEST
> help
> Say Y here if you have the Goodix touchscreen (such as one
> installed in Onda v975w tablets) connected to your
> @@ -1112,7 +1112,8 @@ config TOUCHSCREEN_ZFORCE
>
> config TOUCHSCREEN_COLIBRI_VF50
> tristate "Toradex Colibri on board touchscreen driver"
> - depends on GPIOLIB && IIO && VF610_ADC
> + depends on IIO && VF610_ADC
> + depends on GPIOLIB || COMPILE_TEST
> help
> Say Y here if you have a Colibri VF50 and plan to use
> the on-board provided 4-wire touchscreen driver.
> --
> 1.9.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h>
2016-02-07 14:18 [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Geert Uytterhoeven
2016-02-07 14:18 ` [PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB Geert Uytterhoeven
@ 2016-02-09 18:33 ` Dmitry Torokhov
2016-02-10 9:52 ` Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2016-02-09 18:33 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bastien Nocera, Sanchayan Maity, linux-input, linux-gpio
On Sun, Feb 07, 2016 at 03:18:06PM +0100, Geert Uytterhoeven wrote:
> drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’:
> drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thank you.
> ---
> Seen with "[PATCH 2/2] Input: Allow compile test of Goodix and Colibri
> VF50 if !GPIOLIB" on m68k/allmodconfig
>
> drivers/input/touchscreen/colibri-vf50-ts.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
> index 5d4903a402cc6a5f..69828d015d45ffa4 100644
> --- a/drivers/input/touchscreen/colibri-vf50-ts.c
> +++ b/drivers/input/touchscreen/colibri-vf50-ts.c
> @@ -21,6 +21,7 @@
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> --
> 1.9.1
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h>
2016-02-09 18:33 ` [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Dmitry Torokhov
@ 2016-02-10 9:52 ` Geert Uytterhoeven
2016-02-10 19:38 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-02-10 9:52 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Bastien Nocera, Sanchayan Maity, linux-input@vger.kernel.org,
linux-gpio@vger.kernel.org
On Tue, Feb 9, 2016 at 7:33 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Sun, Feb 07, 2016 at 03:18:06PM +0100, Geert Uytterhoeven wrote:
>> drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’:
>> drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Applied, thank you.
Apparently you only applied patch 2/2, causing the abovementioned
breakage in -next?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h>
2016-02-10 9:52 ` Geert Uytterhoeven
@ 2016-02-10 19:38 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2016-02-10 19:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bastien Nocera, Sanchayan Maity, linux-input@vger.kernel.org,
linux-gpio@vger.kernel.org
On Wed, Feb 10, 2016 at 10:52:39AM +0100, Geert Uytterhoeven wrote:
> On Tue, Feb 9, 2016 at 7:33 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Sun, Feb 07, 2016 at 03:18:06PM +0100, Geert Uytterhoeven wrote:
> >> drivers/input/touchscreen/colibri-vf50-ts.c: In function ‘vf50_ts_probe’:
> >> drivers/input/touchscreen/colibri-vf50-ts.c:302: error: implicit declaration of function ‘of_property_read_u32’
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Applied, thank you.
>
> Apparently you only applied patch 2/2, causing the abovementioned
> breakage in -next?
Hmm, I applied both, the Kconfig change went to next and include went into
for-linus and they both should have ended up in linux-next...
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-10 19:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-07 14:18 [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Geert Uytterhoeven
2016-02-07 14:18 ` [PATCH 2/2] Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB Geert Uytterhoeven
2016-02-09 18:34 ` Dmitry Torokhov
2016-02-09 18:33 ` [PATCH 1/2] Input: Colibri VF50 - Add missing #include <linux/of.h> Dmitry Torokhov
2016-02-10 9:52 ` Geert Uytterhoeven
2016-02-10 19:38 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).