From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Aaron Lu <aaron.lu@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Vincent Pelletier <plr.vincent@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-input@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 3/3] input: gpio_keys: Make use of the device property API
Date: Tue, 23 Feb 2016 09:54:14 -0800 [thread overview]
Message-ID: <20160223175414.GA30638@dtor-ws> (raw)
In-Reply-To: <20160223072950.GJ1770@lahna.fi.intel.com>
On Tue, Feb 23, 2016 at 09:29:50AM +0200, Mika Westerberg wrote:
> On Mon, Feb 22, 2016 at 11:58:15AM -0800, Dmitry Torokhov wrote:
> > On Fri, Feb 19, 2016 at 11:16:22AM +0100, Geert Uytterhoeven wrote:
> > > @@ -887,7 +870,7 @@ static struct platform_driver gpio_keys_device_driver = {
> > > .driver = {
> > > .name = "gpio-keys",
> > > .pm = &gpio_keys_pm_ops,
> > > - .of_match_table = of_match_ptr(gpio_keys_of_match),
> > > + .of_match_table = gpio_keys_of_match,
> >
> > Why are we changing this? I think match table should still be guarded
> > by #ifdef CONFIG_OF.
>
> This allows ACPI "PRP0001" ID to match DT .compatible strings in the
> gpio_keys_of_match[] table.
Ah, I see.
--
Dmitry
next prev parent reply other threads:[~2016-02-23 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 10:16 [PATCH 0/3] input: gpio_keys: Convert to GPIO descriptors Geert Uytterhoeven
2016-02-19 10:16 ` [PATCH 1/3] input: gpio_keys: Add support for " Geert Uytterhoeven
2016-02-19 10:16 ` [PATCH 2/3] input: gpio_keys: Switch from irq_of_parse_and_map() to platform_get_irq() Geert Uytterhoeven
2016-02-23 19:35 ` Dmitry Torokhov
2016-02-19 10:16 ` [PATCH 3/3] input: gpio_keys: Make use of the device property API Geert Uytterhoeven
2016-02-19 10:46 ` Geert Uytterhoeven
2016-02-22 19:58 ` Dmitry Torokhov
2016-02-23 7:29 ` Mika Westerberg
2016-02-23 17:54 ` Dmitry Torokhov [this message]
2016-02-28 2:03 ` sergk sergk2mail
2016-02-29 8:17 ` Mika Westerberg
2016-02-29 16:24 ` sergk sergk2mail
2016-03-01 7:52 ` Mika Westerberg
2016-03-09 3:36 ` Linus Walleij
2016-03-09 8:36 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223175414.GA30638@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aaron.lu@intel.com \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=plr.vincent@gmail.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).