From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] input: goldfish_events: add devicetree bindings Date: Fri, 26 Feb 2016 12:05:25 -0800 Message-ID: <20160226200525.GB3769@dtor-ws> References: <20160226184908.3539.48691.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f173.google.com ([209.85.192.173]:32975 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbcBZUF2 (ORCPT ); Fri, 26 Feb 2016 15:05:28 -0500 Received: by mail-pf0-f173.google.com with SMTP id q63so57105217pfb.0 for ; Fri, 26 Feb 2016 12:05:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160226184908.3539.48691.stgit@localhost.localdomain> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alan Cc: linux-input@vger.kernel.org On Fri, Feb 26, 2016 at 06:49:34PM +0000, Alan wrote: > From: Greg Hackmann > > Add device tree bindings to the Goldfish virtual platform event driver. > > Signed-off-by: Greg Hackmann > Signed-off-by: Jin Qian > Signed-off-by: Alan Applied, thank you. > --- > .../devicetree/bindings/goldfish/events.txt | 17 +++++++++++++++++ > drivers/input/keyboard/goldfish_events.c | 7 +++++++ > 2 files changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/goldfish/events.txt > > diff --git a/Documentation/devicetree/bindings/goldfish/events.txt b/Documentation/devicetree/bindings/goldfish/events.txt > new file mode 100644 > index 0000000..c270066 > --- /dev/null > +++ b/Documentation/devicetree/bindings/goldfish/events.txt > @@ -0,0 +1,17 @@ > +Android Goldfish Events Keypad > + > +Android goldfish events keypad device generated by android emulator. > + > +Required properties: > + > +- compatible : should contain "google,goldfish-events-keypad" to match emulator > +- reg : > +- interrupts : > + > +Example: > + > + goldfish-events@9040000 { > + compatible = "google,goldfish-events-keypad"; > + reg = <0x9040000 0x1000>; > + interrupts = <0x5>; > + }; > diff --git a/drivers/input/keyboard/goldfish_events.c b/drivers/input/keyboard/goldfish_events.c > index 907e4e2..b11d218 100644 > --- a/drivers/input/keyboard/goldfish_events.c > +++ b/drivers/input/keyboard/goldfish_events.c > @@ -178,10 +178,17 @@ static int events_probe(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id goldfish_events_of_match[] = { > + { .compatible = "google,goldfish-events-keypad", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, goldfish_events_of_match); > + > static struct platform_driver events_driver = { > .probe = events_probe, > .driver = { > .name = "goldfish_events", > + .of_match_table = goldfish_events_of_match, > }, > }; > > -- Dmitry