From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org,
lars@opdenkamp.eu, linux@arm.linux.org.uk,
Kamil Debski <kamil@wypas.org>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCHv12 05/17] HID: add HDMI CEC specific keycodes
Date: Sat, 5 Mar 2016 09:50:39 -0800 [thread overview]
Message-ID: <20160305175039.GA23722@dtor-ws> (raw)
In-Reply-To: <56DA9C68.2080702@xs4all.nl>
On Sat, Mar 05, 2016 at 09:44:24AM +0100, Hans Verkuil wrote:
> Hi Dmitry,
>
> On 03/04/2016 08:58 PM, Dmitry Torokhov wrote:
> > On Wed, Feb 10, 2016 at 01:51:39PM +0100, Hans Verkuil wrote:
> >> +#define KEY_AUDIO_DESC 0x26e
> >> +#define KEY_3D_MODE 0x26f
> >> +#define KEY_NEXT_FAVORITE 0x270
> >> +#define KEY_STOP_RECORD 0x271
> >> +#define KEY_PAUSE_RECORD 0x272
> >> +#define KEY_VOD 0x273 /* Video on Demand */
> >> +#define KEY_UNMUTE 0x274
> >> +#define KEY_FASTREVERSE 0x275
> >> +#define KEY_SLOWREVERSE 0x276
> >
> > KEY_FRAMEBACK maybe?
>
> FRAMEBACK suggests to me that it goes back a single frame and then pauses
> at that frame. Whereas SLOWREVERSE is continual slow reverse playback.
>
> So I would prefer to keep it, unless you think otherwise.
OK, fair enough.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2016-03-05 17:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 12:51 [PATCHv12 00/17] HDMI CEC framework Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 01/17] dts: exynos4*: add HDMI CEC pin definition to pinctrl Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 02/17] dts: exynos4: add node for the HDMI CEC device Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 03/17] dts: exynos4412-odroid*: enable " Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 04/17] input.h: add BUS_CEC type Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 05/17] HID: add HDMI CEC specific keycodes Hans Verkuil
2016-02-12 9:27 ` Hans Verkuil
2016-02-24 8:31 ` Hans Verkuil
2016-03-04 12:27 ` Hans Verkuil
2016-03-04 19:58 ` Dmitry Torokhov
2016-03-05 8:44 ` Hans Verkuil
2016-03-05 17:50 ` Dmitry Torokhov [this message]
2016-02-10 12:51 ` [PATCHv12 06/17] rc: Add HDMI CEC protocol handling Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 07/17] cec: add HDMI CEC framework Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 08/17] cec: add compat32 ioctl support Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 09/17] cec.txt: add CEC framework documentation Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 10/17] DocBook/media: add CEC documentation Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 11/17] v4l2-subdev: add HDMI CEC ops Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 12/17] cec: adv7604: add cec support Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 13/17] cec: adv7842: " Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 14/17] cec: adv7511: " Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 15/17] cobalt: " Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 16/17] cec: s5p-cec: Add s5p-cec driver Hans Verkuil
2016-02-10 12:51 ` [PATCHv12 17/17] vivid: add CEC emulation Hans Verkuil
2016-02-11 7:30 ` [PATCHv12 18/17] cec: check for RC_CORE support Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305175039.GA23722@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=kamil@wypas.org \
--cc=lars@opdenkamp.eu \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).