From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCHv12 05/17] HID: add HDMI CEC specific keycodes Date: Sat, 5 Mar 2016 09:50:39 -0800 Message-ID: <20160305175039.GA23722@dtor-ws> References: <1455108711-29850-1-git-send-email-hverkuil@xs4all.nl> <1455108711-29850-6-git-send-email-hverkuil@xs4all.nl> <20160304195827.GE17145@dtor-ws> <56DA9C68.2080702@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56DA9C68.2080702@xs4all.nl> Sender: linux-samsung-soc-owner@vger.kernel.org To: Hans Verkuil Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org, lars@opdenkamp.eu, linux@arm.linux.org.uk, Kamil Debski , Hans Verkuil List-Id: linux-input@vger.kernel.org On Sat, Mar 05, 2016 at 09:44:24AM +0100, Hans Verkuil wrote: > Hi Dmitry, > > On 03/04/2016 08:58 PM, Dmitry Torokhov wrote: > > On Wed, Feb 10, 2016 at 01:51:39PM +0100, Hans Verkuil wrote: > >> +#define KEY_AUDIO_DESC 0x26e > >> +#define KEY_3D_MODE 0x26f > >> +#define KEY_NEXT_FAVORITE 0x270 > >> +#define KEY_STOP_RECORD 0x271 > >> +#define KEY_PAUSE_RECORD 0x272 > >> +#define KEY_VOD 0x273 /* Video on Demand */ > >> +#define KEY_UNMUTE 0x274 > >> +#define KEY_FASTREVERSE 0x275 > >> +#define KEY_SLOWREVERSE 0x276 > > > > KEY_FRAMEBACK maybe? > > FRAMEBACK suggests to me that it goes back a single frame and then pauses > at that frame. Whereas SLOWREVERSE is continual slow reverse playback. > > So I would prefer to keep it, unless you think otherwise. OK, fair enough. Thanks. -- Dmitry