* [PATCH] Input: egalax_ts - remove unused definitions
@ 2016-03-04 22:07 Fabio Estevam
2016-03-11 18:08 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2016-03-04 22:07 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
REPORT_MODE_MOUSE and REPORT_MODE_VENDOR are never used in the driver,
so let's just remove them.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/input/touchscreen/egalax_ts.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 1afc08b..a260476 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -29,18 +29,6 @@
#include <linux/input/mt.h>
#include <linux/of_gpio.h>
-/*
- * Mouse Mode: some panel may configure the controller to mouse mode,
- * which can only report one point at a given time.
- * This driver will ignore events in this mode.
- */
-#define REPORT_MODE_MOUSE 0x1
-/*
- * Vendor Mode: this mode is used to transfer some vendor specific
- * messages.
- * This driver will ignore events in this mode.
- */
-#define REPORT_MODE_VENDOR 0x3
/* Multiple Touch Mode */
#define REPORT_MODE_MTTOUCH 0x4
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: egalax_ts - remove unused definitions
2016-03-04 22:07 [PATCH] Input: egalax_ts - remove unused definitions Fabio Estevam
@ 2016-03-11 18:08 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-03-11 18:08 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-input, Fabio Estevam
Hi Fabio,
On Fri, Mar 04, 2016 at 07:07:58PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> REPORT_MODE_MOUSE and REPORT_MODE_VENDOR are never used in the driver,
> so let's just remove them.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/input/touchscreen/egalax_ts.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
> index 1afc08b..a260476 100644
> --- a/drivers/input/touchscreen/egalax_ts.c
> +++ b/drivers/input/touchscreen/egalax_ts.c
> @@ -29,18 +29,6 @@
> #include <linux/input/mt.h>
> #include <linux/of_gpio.h>
>
> -/*
> - * Mouse Mode: some panel may configure the controller to mouse mode,
> - * which can only report one point at a given time.
> - * This driver will ignore events in this mode.
> - */
> -#define REPORT_MODE_MOUSE 0x1
> -/*
> - * Vendor Mode: this mode is used to transfer some vendor specific
> - * messages.
> - * This driver will ignore events in this mode.
> - */
> -#define REPORT_MODE_VENDOR 0x3
Keeping this does not add to runtime size and is not excessive, I do not
see harm in not keeping it.
> /* Multiple Touch Mode */
> #define REPORT_MODE_MTTOUCH 0x4
>
> --
> 1.9.1
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-04 22:07 [PATCH] Input: egalax_ts - remove unused definitions Fabio Estevam
2016-03-11 18:08 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).