From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Andrew Duggan <aduggan@synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again
Date: Thu, 17 Mar 2016 17:14:19 -0700 [thread overview]
Message-ID: <20160318001419.GD21461@dtor-ws> (raw)
In-Reply-To: <1458037097-6444-1-git-send-email-benjamin.tissoires@redhat.com>
On Tue, Mar 15, 2016 at 11:18:17AM +0100, Benjamin Tissoires wrote:
> Looks like the fimware 8.2 stall has the extra buttons spurious release
> bug.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=114321
> Cc: stable@vger.kernel.org
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
> ---
> drivers/input/mouse/synaptics.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 6025eb4..9f3b83f 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -862,8 +862,9 @@ static void synaptics_report_ext_buttons(struct psmouse *psmouse,
> if (!SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap))
> return;
>
> - /* Bug in FW 8.1, buttons are reported only when ExtBit is 1 */
> - if (SYN_ID_FULL(priv->identity) == 0x801 &&
> + /* Bug in FW 8.1 & 8.2, buttons are reported only when ExtBit is 1 */
> + if (((SYN_ID_FULL(priv->identity) == 0x801) ||
> + (SYN_ID_FULL(priv->identity) == 0x802)) &&
but dropped extra parenthesis...
> !((psmouse->packet[0] ^ psmouse->packet[3]) & 0x02))
> return;
>
> --
> 2.5.0
>
--
Dmitry
prev parent reply other threads:[~2016-03-18 0:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 10:18 [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again Benjamin Tissoires
2016-03-15 14:25 ` Benjamin Tissoires
2016-03-18 0:14 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318001419.GD21461@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).