From: Rob Herring <robh@kernel.org>
To: "jeffrey.lin" <yajohn@gmail.com>
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
jc+devicetree@hellion.org.uk, galak@codeaurora.org,
treding@nvidia.com, inki.dae@samsung.com, djkurtz@chromium.org,
dusonlin@emc.com.tw, ajaykumar.rs@samsung.com, jeesw@melfas.com,
dmitry.torokhov@gmail.com, rydberg@euromail.se,
grant.likely@linaro.org, bleung@chromium.org,
scott.liu@emc.com.tw, jeffrey.lin@rad-ic.com,
roger.yang@rad-ic.com, KP.li@rad-ic.com, albert.shieh@rad-ic.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Date: Fri, 18 Mar 2016 16:04:50 -0500 [thread overview]
Message-ID: <20160318210450.GA28913@rob-hp-laptop> (raw)
In-Reply-To: <1458031457-1315-1-git-send-email-jeffrey.lin@rad-ic.com>
On Tue, Mar 15, 2016 at 04:44:17PM +0800, jeffrey.lin wrote:
> Raydium I2C touch driver.
>
> Signed-off-by: jeffrey.lin <jeffrey.lin@rad-ic.com>
> ---
> .../devicetree/bindings/input/raydium_i2c_ts.txt | 23 +
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
It is generally preferred to split bindings from driver changes.
> drivers/input/touchscreen/Kconfig | 12 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/raydium_i2c_ts.c | 932 +++++++++++++++++++++
> 5 files changed, 969 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/raydium_i2c_ts.txt
> create mode 100644 drivers/input/touchscreen/raydium_i2c_ts.c
>
> diff --git a/Documentation/devicetree/bindings/input/raydium_i2c_ts.txt b/Documentation/devicetree/bindings/input/raydium_i2c_ts.txt
> new file mode 100644
> index 0000000..329864d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/raydium_i2c_ts.txt
> @@ -0,0 +1,23 @@
> +Raydium I2C touchscreen
> +
> +Required properties:
> +- compatible:
> + "raydium,rm31100"
> +
> +- reg: The I2C address of the device
> +- interrupts: interrupt to which the chip is connected
> + See ../interrupt-controller/interrupts.txt
> +Optional property:
> + - avdd-supply : Analog power supply needed to power device
> + - vccio-supply: IO Power source
> +
> +Example:
> +
> + raydium_i2c@0x39 {
touchscreen@39
Otherwise,
Acked-by: Rob Herring <robh@kernel.org>
> + compatible = "raydium,rm31100";
> + avdd-supply = <&pm8226_l19>;
> + vccio-supply = <&pm8226_lvs1>;
> + reg = <0x39>;
> + interrupt-parent = <&gpio>;
> + interrupts = <0x0 IRQ_TYPE_EDGE_FALLING>;
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index af49e0f..5b6224b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -126,6 +126,7 @@ radxa Radxa
> raidsonic RaidSonic Technology GmbH
> ralink Mediatek/Ralink Technology Corp.
> ramtron Ramtron International
> +raydium Raydium Semiconductor Corp.
> realtek Realtek Semiconductor Corp.
> renesas Renesas Electronics Corporation
> ricoh Ricoh Co. Ltd.
next prev parent reply other threads:[~2016-03-18 21:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 8:44 [PATCH] driver: input :touchscreen : add Raydium I2C touch driver jeffrey.lin
2016-03-18 21:04 ` Rob Herring [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-24 9:05 jeffrey.lin
2016-05-17 15:34 jeffrey.lin
2016-05-11 13:51 jeffrey.lin
2016-04-29 9:45 jeffrey.lin
2016-05-04 22:58 ` Dmitry Torokhov
2016-05-06 8:24 ` jeffrey.lin
2016-05-11 16:04 ` jeffrey.lin
[not found] ` <1461923113-426-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-13 4:18 ` Dmitry Torokhov
2016-05-13 17:08 ` jeffrey.lin
2016-05-16 15:46 ` jeffrey.lin
[not found] ` <1463413611-367-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-16 16:41 ` Dmitry Torokhov
2016-05-16 16:43 ` Dmitry Torokhov
2016-05-16 15:57 ` jeffrey.lin
2016-05-17 16:07 ` jeffrey.lin
[not found] ` <1463501223-20723-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-21 18:18 ` Dmitry Torokhov
2016-05-22 9:32 ` jeffrey.lin
2016-05-22 22:37 ` Dmitry Torokhov
2016-05-22 9:35 ` jeffrey.lin
2016-05-23 14:43 ` jeffrey.lin
[not found] ` <1464014633-20829-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-23 16:27 ` Dmitry Torokhov
2016-05-24 9:31 ` jeffrey.lin
[not found] ` <1464082301-11539-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-27 16:34 ` Dmitry Torokhov
2016-04-22 10:01 dan.huang
[not found] ` <1461319268-362-1-git-send-email-dan.huang-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-04-22 22:50 ` Dmitry Torokhov
2016-03-25 5:21 jeffrey.lin
2016-04-11 8:24 ` Dmitry Torokhov
2016-04-11 9:57 ` Jeffrey Lin (林義章)
2016-04-14 9:28 ` Jeffrey Lin (林義章)
2016-03-22 6:23 jeffrey.lin
2016-03-03 6:42 jeffrey.lin
2016-03-10 18:47 ` Dmitry Torokhov
2016-03-11 2:10 ` Jeffrey Lin (林義章)
2016-03-03 2:29 jeffrey.lin
2016-03-03 2:44 ` Joe Perches
2016-03-03 3:14 ` Jeffrey Lin (林義章)
2016-03-03 3:55 ` Joe Perches
2016-02-23 8:11 jeffrey.lin
2016-01-21 4:02 Jeffrey Lin
2016-01-21 9:37 ` Dmitry Torokhov
2016-01-15 3:30 Jeffrey Lin
2016-01-13 7:49 Jeffrey Lin
2016-01-13 8:31 ` Dmitry Torokhov
2016-01-13 19:14 ` Dmitry Torokhov
2016-01-13 6:23 Jeffrey Lin
2016-01-13 6:44 ` Dmitry Torokhov
2016-01-08 15:17 Jeffrey Lin
2016-01-09 19:20 ` Dmitry Torokhov
2015-01-06 9:25 jeffrey.lin
2015-01-06 19:43 ` Jeremiah Mahler
2015-01-07 0:40 ` Dmitry Torokhov
2014-12-08 3:42 jeffrey.lin
2014-12-05 8:15 jeffrey.lin
2014-12-05 15:04 ` Dmitry Torokhov
2014-11-14 7:19 jeffrey.lin
2014-11-14 17:43 ` Benson Leung
2014-11-14 18:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318210450.GA28913@rob-hp-laptop \
--to=robh@kernel.org \
--cc=KP.li@rad-ic.com \
--cc=ajaykumar.rs@samsung.com \
--cc=albert.shieh@rad-ic.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dusonlin@emc.com.tw \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=inki.dae@samsung.com \
--cc=jc+devicetree@hellion.org.uk \
--cc=jeesw@melfas.com \
--cc=jeffrey.lin@rad-ic.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=roger.yang@rad-ic.com \
--cc=rydberg@euromail.se \
--cc=scott.liu@emc.com.tw \
--cc=treding@nvidia.com \
--cc=yajohn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox