From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Anthony Olech <anthony.olech.opensource@diasemi.com>,
stwiss.opensource@diasemi.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@cam.ac.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
rtc-linux@googlegroups.com
Subject: Re: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver
Date: Wed, 23 Mar 2016 02:31:39 +0100 [thread overview]
Message-ID: <20160323013139.GD2365@piout.net> (raw)
In-Reply-To: <201304191703.r3JH3du0017574@latitude>
Hi Anthony, Steve,
This driver has been submitted a while ago and reached v6 but still had
a few comments. Do you still have some interest in seeing it being
accepted?
On 19/04/2013 at 17:56:29 +0100, Anthony Olech wrote :
> This is submission attempt number 6 to have this driver included in
> the linux kernel source tree. This is the driver for the Dialog DA9058.
>
> The DA9058 is a low power Power Management Integrated Circuit with extra
> functionality. It is a Multi Function Device controlled only from an I2C
> bus whose components can raise an interrupt request on a single IRQ line.
>
> The driver for the DA9058 consists of a core (i2c) device driver that
> instantiates the individual component device drivers for:
>
> adc - 5 ADC channels
> gpio - 2 available pins
> onkey - 1 device
> regulator - 4 BUCKS, 19 LDO and 3 fixed
> rtc - low power clock
> hwmon - 5 monitored voltages/temperatures
>
> All the above six component device drivers depend on the 'core'
> component driver, which is number one in the patch series.
>
> Each component driver for the Dialog DA9058 will follow as an e-mail
> patch relative to
>
> This driver has been tested on a Samsung SMDK6410 connected to a Dialog
> DA9058 Evaluation Board via one GPIO and a 3-wire I2C connection.
>
> All the components can be builtin to the kernel or compiled as modules.
> As far as I can tell, all the latest APIs both for the core driver and
> all the component drivers have been adhered to, but if I have missed
> something please let me know.
>
> In a clean check out of next-20130419 in linux-next, each patch has been
> applied individually and the final result has been built successfully.
>
> Many thanks,
> Anthony Olech, Dialog Semiconductor Ltd.
>
> Tony Olech (at Home) (7):
> drivers/mfd: DA9058 MFD core driver
> drivers/iio/adc: DA9058 ADC driver
> drivers/input/misc: DA9058 ONKEY driver
> drivers/rtc: DA9058 RTC driver
> drivers/gpio: DA9058 GPIO driver
> drivers/hwmon: DA9058 HWMON driver
> drivers/regulator: DA9058 REGULATOR driver
>
> Documentation/hwmon/da9058 | 38 ++
> drivers/gpio/Kconfig | 12 +
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-da9058.c | 376 ++++++++++++++
> drivers/hwmon/Kconfig | 10 +
> drivers/hwmon/Makefile | 3 +-
> drivers/hwmon/da9058-hwmon.c | 330 ++++++++++++
> drivers/iio/adc/Kconfig | 12 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/da9058-adc.c | 396 ++++++++++++++
> drivers/input/misc/Kconfig | 10 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/da9058_onkey.c | 173 +++++++
> drivers/mfd/Kconfig | 17 +
> drivers/mfd/Makefile | 3 +
> drivers/mfd/da9058-core.c | 73 +++
> drivers/mfd/da9058-i2c.c | 96 ++++
> drivers/mfd/da9058-info.c | 939 ++++++++++++++++++++++++++++++++++
> drivers/mfd/da9058-irq.c | 56 ++
> drivers/regulator/Kconfig | 11 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/da9058-regulator.c | 199 +++++++
> drivers/rtc/Kconfig | 10 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-da9058.c | 448 ++++++++++++++++
> include/linux/mfd/da9058/adc.h | 18 +
> include/linux/mfd/da9058/bat.h | 33 ++
> include/linux/mfd/da9058/codec.h | 22 +
> include/linux/mfd/da9058/conf.h | 22 +
> include/linux/mfd/da9058/core.h | 66 +++
> include/linux/mfd/da9058/gpio.h | 19 +
> include/linux/mfd/da9058/hwmon.h | 32 ++
> include/linux/mfd/da9058/i2c.h | 22 +
> include/linux/mfd/da9058/irq.h | 50 ++
> include/linux/mfd/da9058/onkey.h | 17 +
> include/linux/mfd/da9058/pdata.h | 30 ++
> include/linux/mfd/da9058/registers.h | 480 +++++++++++++++++
> include/linux/mfd/da9058/regulator.h | 26 +
> include/linux/mfd/da9058/rtc.h | 17 +
> 39 files changed, 4070 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/hwmon/da9058
> create mode 100644 drivers/gpio/gpio-da9058.c
> create mode 100644 drivers/hwmon/da9058-hwmon.c
> create mode 100644 drivers/iio/adc/da9058-adc.c
> create mode 100644 drivers/input/misc/da9058_onkey.c
> create mode 100644 drivers/mfd/da9058-core.c
> create mode 100644 drivers/mfd/da9058-i2c.c
> create mode 100644 drivers/mfd/da9058-info.c
> create mode 100644 drivers/mfd/da9058-irq.c
> create mode 100644 drivers/regulator/da9058-regulator.c
> create mode 100644 drivers/rtc/rtc-da9058.c
> create mode 100644 include/linux/mfd/da9058/adc.h
> create mode 100644 include/linux/mfd/da9058/bat.h
> create mode 100644 include/linux/mfd/da9058/codec.h
> create mode 100644 include/linux/mfd/da9058/conf.h
> create mode 100644 include/linux/mfd/da9058/core.h
> create mode 100644 include/linux/mfd/da9058/gpio.h
> create mode 100644 include/linux/mfd/da9058/hwmon.h
> create mode 100644 include/linux/mfd/da9058/i2c.h
> create mode 100644 include/linux/mfd/da9058/irq.h
> create mode 100644 include/linux/mfd/da9058/onkey.h
> create mode 100644 include/linux/mfd/da9058/pdata.h
> create mode 100644 include/linux/mfd/da9058/registers.h
> create mode 100644 include/linux/mfd/da9058/regulator.h
> create mode 100644 include/linux/mfd/da9058/rtc.h
>
> --
> end-of-patch for NEW DRIVER V6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-23 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 16:56 [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver Anthony Olech
2016-03-23 1:31 ` Alexandre Belloni [this message]
2016-03-23 11:33 ` Opensource [Steve Twiss]
2016-03-23 17:47 ` Opensource [Steve Twiss]
[not found] ` <6ED8E3B22081A4459DAC7699F3695FB70173D800D3@SW-EX-MBX02.diasemi.com>
2016-03-23 18:08 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2013-04-19 16:56 Anthony Olech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323013139.GD2365@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=anthony.olech.opensource@diasemi.com \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@xenotime.net \
--cc=rtc-linux@googlegroups.com \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).