linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: jikos@kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, bleung@chromium.org
Subject: Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume
Date: Wed, 30 Mar 2016 09:46:28 +0200	[thread overview]
Message-ID: <20160330074628.GE20424@mail.corp.redhat.com> (raw)
In-Reply-To: <1459282241-25154-1-git-send-email-gabriele.mzt@gmail.com>

On Mar 29 2016 or thereabouts, Gabriele Mazzotta wrote:
> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>

Thanks for the fix (I should have spot that earlier :( )

Reviewed-by: Benjamin TIssoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

> ---
>  drivers/hid/hid-multitouch.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
>  							   MT_TOOL_FINGER,
>  							   false);
>  			}
> +			input_mt_sync_frame(input_dev);
>  			input_sync(input_dev);
>  		}
>  	}
> -- 
> 2.8.0.rc3
> 

  parent reply	other threads:[~2016-03-30  7:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 20:10 [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Gabriele Mazzotta
2016-03-29 20:36 ` Benson Leung
2016-03-30  7:46 ` Benjamin Tissoires [this message]
2016-04-01  9:35 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330074628.GE20424@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=bleung@chromium.org \
    --cc=gabriele.mzt@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).