From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Oliver Neukum <oneukum-IBi9RG/b67k@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] acecad: stop saving struct usb_device
Date: Thu, 31 Mar 2016 11:03:42 -0700 [thread overview]
Message-ID: <20160331180342.GG39098@dtor-ws> (raw)
In-Reply-To: <1458659097-8213-2-git-send-email-oneukum-IBi9RG/b67k@public.gmane.org>
On Tue, Mar 22, 2016 at 04:04:54PM +0100, Oliver Neukum wrote:
> static int usb_acecad_open(struct input_dev *dev)
> {
> struct usb_acecad *acecad = input_get_drvdata(dev);
>
> - acecad->irq->dev = acecad->usbdev;
> + acecad->irq->dev = interface_to_usbdev(acecad->intf);
By the way, do we still need to do this assignment before submitting
urb?
> if (usb_submit_urb(acecad->irq, GFP_KERNEL))
> return -EIO;
>
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-31 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 15:04 [PATCH 0/4] tablet: remove private copy to USB device Oliver Neukum
2016-03-22 15:04 ` [PATCH 1/4] acecad: stop saving struct usb_device Oliver Neukum
[not found] ` <1458659097-8213-2-git-send-email-oneukum-IBi9RG/b67k@public.gmane.org>
2016-03-31 18:03 ` Dmitry Torokhov [this message]
2016-03-22 15:04 ` [PATCH 2/4] aiptek: " Oliver Neukum
[not found] ` <1458659097-8213-3-git-send-email-oneukum-IBi9RG/b67k@public.gmane.org>
2016-03-22 16:33 ` kbuild test robot
2016-03-22 16:33 ` [PATCH] aiptek: fix semicolon.cocci warnings kbuild test robot
[not found] ` <1458659097-8213-1-git-send-email-oneukum-IBi9RG/b67k@public.gmane.org>
2016-03-22 15:04 ` [PATCH 3/4] gtco: stop saving struct usb_device Oliver Neukum
2016-03-22 15:04 ` [PATCH 4/4] kbtab: " Oliver Neukum
2016-03-31 18:02 ` [PATCH 0/4] tablet: remove private copy to USB device Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331180342.GG39098@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oneukum-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).