From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v4 3/3] ARM: dts: use syscon in cygnus touchscreen dt node Date: Wed, 6 Apr 2016 10:31:40 -0700 Message-ID: <20160406173140.GB38452@dtor-ws> References: <1456556396-4759-1-git-send-email-raveendra.padasalagi@broadcom.com> <1456556396-4759-4-git-send-email-raveendra.padasalagi@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1456556396-4759-4-git-send-email-raveendra.padasalagi-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Raveendra Padasalagi Cc: Russell King , Rob Herring , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Richardson , Jon Mason , Florian Fainelli , Anup Patel , Ray Jui , Scott Branden , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: linux-input@vger.kernel.org On Sat, Feb 27, 2016 at 12:29:56PM +0530, Raveendra Padasalagi wrote: > In Cygnus SOC touch screen controller registers are shared > with ADC and flex timer. Using readl/writel could lead to > race condition. So touchscreen driver is enhanced to support > syscon based register access to take care of mutually exclusive > access. > > This patch enables syscon support in touchscreen driver > by adding necessary properties in touchscreen dt node and > in addition to this renamed existing "tsc" touchscreen node > name to "touchscreen". > > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden OK, since the new dts is really needed for the driver I'll be folding this into the touchscreen driver patch unless I hear someone yelling at me. Thanks! > --- > arch/arm/boot/dts/bcm-cygnus.dtsi | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi > index 3878793..b42fe55 100644 > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > @@ -351,9 +351,16 @@ > <&pinctrl 142 10 1>; > }; > > - touchscreen: tsc@180a6000 { > + ts_adc_syscon: ts_adc_syscon@180a6000 { > + compatible = "brcm,iproc-ts-adc-syscon", "syscon"; > + reg = <0x180a6000 0xc30>; > + }; > + > + touchscreen: touchscreen@180a6000 { > compatible = "brcm,iproc-touchscreen"; > - reg = <0x180a6000 0x40>; > + #address-cells = <1>; > + #size-cells = <1>; > + ts_syscon = <&ts_adc_syscon>; > clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>; > clock-names = "tsc_clk"; > interrupts = ; > -- > 1.9.1 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html