From: Lee Jones <lee.jones@linaro.org>
To: Marcin Niestroj <m.niestroj@grinn-global.com>, broonie@kernel.org
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Tony Lindgren <tony@atomide.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
linux-omap@vger.kernel.org, linux-pm@vger.kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] mfd: tps65217: Add support for IRQs
Date: Mon, 11 Apr 2016 10:44:26 +0100 [thread overview]
Message-ID: <20160411094426.GB8094@x1> (raw)
In-Reply-To: <57039E74.7030704@grinn-global.com>
FAO Mark,
> On 05.04.2016 12:07, Grygorii Strashko wrote:
> >On 04/04/2016 08:11 PM, Marcin Niestroj wrote:
> >>Add support for handling IRQs: power button, AC and USB power state
> >>changes. Mask and interrupt bits are shared within one register, which
> >>prevents us to use regmap_irq implementation. New irq_domain is
> >>created in
> >>order to add interrupt handling for each tps65217's subsystem. IRQ
> >>resources have been added for charger subsystem to be able to notify
> >>about
> >>AC and USB state changes.
> >>
> >>Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> >>---
> >
> >Just curious Why not use a regmap_irq?
>
> tps65217 has IRQ mask and status bits in a single register.
> regmap_irq works in case of two different registers (one mask, one
> status), but with the same layout of mask and status bits in both.
Mark, is this the right approach? Or is there another way regmap_irq
can be manipulated to support this configuration?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-11 9:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:10 [PATCH 0/5] mfd: tps65217: Add power-button and IRQ support Marcin Niestroj
[not found] ` <1459789865-3704-1-git-send-email-m.niestroj-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org>
2016-04-04 17:11 ` [PATCH 0/5] mfd: tps65217: Add power-button support Marcin Niestroj
2016-04-04 17:11 ` [PATCH 1/5] mfd: tps65217: Add support for IRQs Marcin Niestroj
2016-04-05 10:07 ` Grygorii Strashko
2016-04-05 11:16 ` Marcin Niestroj
2016-04-11 8:48 ` Grygorii Strashko
2016-04-11 9:44 ` Lee Jones [this message]
2016-04-25 10:50 ` Marcin Niestroj
2016-04-04 17:11 ` [PATCH 2/5] power_supply: tps65217-charger: Fix NULL deref during property export Marcin Niestroj
2016-04-04 17:11 ` [PATCH 3/5] power_supply: tps65217-charger: Add support for IRQs Marcin Niestroj
2016-04-04 17:11 ` [PATCH 4/5] mfd: tps65217: Add power button as subdevice Marcin Niestroj
2016-04-11 9:44 ` Lee Jones
2016-04-11 10:27 ` Grygorii Strashko
2016-04-11 10:37 ` Lee Jones
2016-04-11 11:05 ` Grygorii Strashko
2016-04-11 12:35 ` Lee Jones
2016-04-04 17:11 ` [PATCH 5/5] Input: Add tps65217 power button driver Marcin Niestroj
2016-04-07 17:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411094426.GB8094@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.niestroj@grinn-global.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).