From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/5] mfd: tps65217: Add support for IRQs Date: Mon, 11 Apr 2016 10:44:26 +0100 Message-ID: <20160411094426.GB8094@x1> References: <1459789865-3704-1-git-send-email-m.niestroj@grinn-global.com> <1459789865-3704-3-git-send-email-m.niestroj@grinn-global.com> <57038E46.9070204@ti.com> <57039E74.7030704@grinn-global.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f48.google.com ([74.125.82.48]:33166 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbcDKJob (ORCPT ); Mon, 11 Apr 2016 05:44:31 -0400 Received: by mail-wm0-f48.google.com with SMTP id f198so137744303wme.0 for ; Mon, 11 Apr 2016 02:44:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <57039E74.7030704@grinn-global.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Marcin Niestroj , broonie@kernel.org Cc: Grygorii Strashko , Tony Lindgren , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , linux-omap@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org =46AO Mark, > On 05.04.2016 12:07, Grygorii Strashko wrote: > >On 04/04/2016 08:11 PM, Marcin Niestroj wrote: > >>Add support for handling IRQs: power button, AC and USB power state > >>changes. Mask and interrupt bits are shared within one register, wh= ich > >>prevents us to use regmap_irq implementation. New irq_domain is > >>created in > >>order to add interrupt handling for each tps65217's subsystem. IRQ > >>resources have been added for charger subsystem to be able to notif= y > >>about > >>AC and USB state changes. > >> > >>Signed-off-by: Marcin Niestroj > >>--- > > > >Just curious Why not use a regmap_irq? >=20 > tps65217 has IRQ mask and status bits in a single register. > regmap_irq works in case of two different registers (one mask, one > status), but with the same layout of mask and status bits in both. Mark, is this the right approach? Or is there another way regmap_irq can be manipulated to support this configuration? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html