From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Laws <mdl@60hz.org>
Cc: devel@linuxdriverproject.org, haiyangz@microsoft.com,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: i8042 - Fix console keyboard support on Gen2 Hyper-V VMs
Date: Mon, 18 Apr 2016 23:36:01 +0300 [thread overview]
Message-ID: <20160418203600.GH4298@mwanda> (raw)
In-Reply-To: <CADemMPN5wPjDzrLnsWgBHKZt3JNN-tYeJ8B+waFVsizZJdi2tA@mail.gmail.com>
On Tue, Apr 19, 2016 at 02:24:47AM +0900, Mark Laws wrote:
> On Tue, Apr 19, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > So if the user inserts the module without a keyboard then in the
> > original code they would just put a keyboard in and try again. Now they
> > have to do an extra rmmod. What about if we just removed the test for
> > if the keyboard is present?
>
> Sorry, I don't understand--which part are you suggesting we remove?
>
The call to i8042_controller_check() or move it to the probe function or
something. Why must we have the hardware to load the module?
regards,
dan carpenter
next prev parent reply other threads:[~2016-04-18 20:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 3:30 [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y Dexuan Cui
2014-08-12 3:21 ` Greg KH
2014-08-12 5:51 ` Dexuan Cui
2014-08-12 6:01 ` Greg KH
2014-08-12 7:15 ` Dexuan Cui
2014-08-12 17:54 ` Dmitry Torokhov
2014-08-12 18:01 ` KY Srinivasan
2014-08-13 5:27 ` Dexuan Cui
2014-08-13 5:24 ` Dexuan Cui
2014-08-13 15:56 ` Dmitry Torokhov
2014-08-14 6:07 ` Dexuan Cui
2016-04-18 15:23 ` [PATCH] Input: i8042 - Fix console keyboard support on Gen2 Hyper-V VMs Mark Laws
2016-04-18 15:23 ` Mark Laws
2016-04-18 16:54 ` Dan Carpenter
2016-04-18 17:24 ` Mark Laws
2016-04-18 20:36 ` Dan Carpenter [this message]
2016-04-18 22:00 ` Mark Laws
2016-04-19 8:22 ` Dan Carpenter
2016-04-19 10:46 ` Mark Laws
2016-04-22 13:00 ` Mark Laws
2016-04-22 13:01 ` Mark Laws
2016-04-22 13:17 ` Dan Carpenter
2016-04-22 17:30 ` Mark Laws
2016-04-22 17:30 ` Mark Laws
-- strict thread matches above, loose matches on Subject: below --
2016-06-13 14:38 Mark Laws
2016-06-13 14:38 ` Mark Laws
2016-06-13 20:45 ` [PATCH] [PATCH] Input: i8042 - Fix console keyboard support on Mark Laws
2016-06-13 20:45 ` [PATCH] Input: i8042 - Fix console keyboard support on Gen2 Hyper-V VMs Mark Laws
[not found] <CADemMPNEv+kq21rXQMmB_BjgTsnEjscOCS5A02VAapOOM-ryMA@mail.gmail.com>
2016-07-25 21:01 ` Dmitry Torokhov
2016-07-25 22:15 ` Mark Laws
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418203600.GH4298@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-input@vger.kernel.org \
--cc=mdl@60hz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).