Re: [PATCH] hid: thingm: remove not needed error message

[Benjamin Tissoires <benjamin.tissoires@redhat.com>]

On Apr 20 2016 or thereabouts, Heiner Kallweit wrote:
> LED core takes care of handling failed calls to thingm_let_set.
> - print error message in set_brightness_delayed or
> - pass error to caller in led_set_brightness_sync
> Also the error message here doesn't provide any hint what actually
> went wrong. Therefore remove it.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Works for me:

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@rehat.com>

> ---
>  drivers/hid/hid-thingm.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/hid/hid-thingm.c b/drivers/hid/hid-thingm.c
> index 2507bbe..9ad9c6e 100644
> --- a/drivers/hid/hid-thingm.c
> +++ b/drivers/hid/hid-thingm.c
> @@ -148,13 +148,8 @@ static int thingm_led_set(struct led_classdev *ldev,
>  			  enum led_brightness brightness)
>  {
>  	struct thingm_led *led = container_of(ldev, struct thingm_led, ldev);
> -	int ret;
> -
> -	ret = thingm_write_color(led->rgb);
> -	if (ret)
> -		hid_err(led->rgb->tdev->hdev, "failed to write color\n");
>  
> -	return ret;
> +	return thingm_write_color(led->rgb);
>  }
>  
>  static int thingm_init_led(struct thingm_led *led, const char *color_name,
> -- 
> 2.8.0
>