From: Rob Herring <robh@kernel.org>
To: Grant Grundler <grundler@chromium.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Hung-yu Wu <hywu@google.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH] dt: add Atmel Captouch bindings
Date: Sat, 14 May 2016 09:52:05 -0500 [thread overview]
Message-ID: <20160514145205.GA31009@rob-hp-laptop> (raw)
In-Reply-To: <1462932469-122552-1-git-send-email-grundler@chromium.org>
On Tue, May 10, 2016 at 07:07:48PM -0700, Grant Grundler wrote:
> From: Daniel Hung-yu Wu <hywu@google.com>
>
> Add binding for Atmel Capacitive Touch Button device.
>
> Signed-off-by: Daniel Hung-yu Wu <hywu@google.com>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> ---
> .../devicetree/bindings/input/atmel,captouch.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/atmel,captouch.txt
>
> I haven't posted the corresponding device driver and dtsi changes yet but will shortly.
>
> V2: split Documentation/devicetree/bindings from driver patch
> rename "atmel,atmegaxx_captouch" to "atmel,captouch" since it's irrelevant
> which controller implements the register set/controller.
Is there any notion of firmware versions though?
>
> V1: posted https://lkml.org/lkml/2016/5/3/613
>
> diff --git a/Documentation/devicetree/bindings/input/atmel,captouch.txt b/Documentation/devicetree/bindings/input/atmel,captouch.txt
> new file mode 100644
> index 0000000..405d287
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atmel,captouch.txt
> @@ -0,0 +1,34 @@
> +Device tree bindings for Atmel AtmegaXX capacitive touch sensor
> +
> +The node for this device must be a child of a I2C controller node, as the
> +device communicates via I2C.
> +
> +Required properties:
> +
> + compatible: Must be "atmel,captouch".
> + reg: The I2C slave address of the device.
> + interrupts: Property describing the interrupt line the device
> + is connected to. The device only has one interrupt
> + source.
> + linux,keycodes: Specifies an array of numeric keycode values to
> + be used for reporting button presses. The array can
> + contain up to 8 entries.
> +
> +Optional properties:
> +
> + autorepeat: Enables the Linux input system's autorepeat
> + feature on the input device.
> +
> +Example:
> +
> + atmel_captouch@51 {
No underscores in node names please.
> + compatible = "atmel,captouch";
> + reg = <0x51>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <67 IRQ_TYPE_EDGE_FALLING>;
> + linux,keycodes = <BTN_0>, <BTN_1>,
> + <BTN_2>, <BTN_3>,
> + <BTN_4>, <BTN_5>,
> + <BTN_6>, <BTN_7>;
> + autorepeat;
> + };
> --
> 2.1.2
>
next prev parent reply other threads:[~2016-05-14 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 2:07 [PATCH] dt: add Atmel Captouch bindings Grant Grundler
[not found] ` <1462932469-122552-1-git-send-email-grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-05-11 2:07 ` [PATCH 2/3 V2] Input: add Atmel Captouch Button driver Grant Grundler
2016-05-13 18:16 ` Grant Grundler
2016-05-13 18:38 ` [PATCH] dt: add Atmel Captouch bindings Dmitry Torokhov
2016-05-14 14:52 ` Rob Herring [this message]
2016-05-16 16:50 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160514145205.GA31009@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=grundler@chromium.org \
--cc=hywu@google.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox