linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: 廖崇榮 <kt.liao@emc.com.tw>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	zac.hsieh@emc.com.tw, "黃世鵬 經理" <phoenix@emc.com.tw>,
	"'Charles Mooney'" <charliemooney@google.com>,
	"'Agnes Cheng'" <agnescheng@google.com>
Subject: Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger
Date: Mon, 16 May 2016 10:53:42 -0700	[thread overview]
Message-ID: <20160516175342.GD12752@dtor-ws> (raw)
In-Reply-To: <00be01d1af65$ec37c290$c4a747b0$@emc.com.tw>

Hi Kt,

On Mon, May 16, 2016 at 07:27:25PM +0800, 廖崇榮 wrote:
> 
> Only ABS_DISTANCE is not enough for upper OS to distingiush hover event be
> triggered from object from faraway to and close touchpad surface or from
> object prepare to leave the touchpad surface. Add BTN_TOOL_FINGER flag to
> help it.
> 
>                  object_from_faraway    object_inside_hover_area
> object_touch_surface
> BTN_TOUCH                 0                          0             1
> BTN_TOOL_FINGER           0                          1              1
> ABS_DISTANCE               0                           1             0
> 
> Signed-off by: Duson Lin <dusonlin@emc.com.tw>

I was wondering if we could do without modifying all the drivers that
are using input_mt_report_pointer_emulation(), by figuring out if we
should be emitting BTN_TOOL_FINGER right there:

"If device supports ABS_DISTANCE and does not support ABS_MT_DISTANCE and
ABS_DISTANCE != 0 is reported in current frame and there are no other
contacts then report BTN_TOOL_FINGER."

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-05-16 17:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06  0:34 [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger duson
     [not found] ` <006901d1acea$8207d090$861771b0$@emc.com.tw>
2016-05-16 11:27   ` 廖崇榮
2016-05-16 17:53     ` Dmitry Torokhov [this message]
2016-05-17 14:20       ` 廖崇榮
2016-05-20  0:51         ` 'Dmitry Torokhov'
2016-05-23 14:28           ` 廖崇榮
2016-05-26  0:11             ` 'Dmitry Torokhov'
  -- strict thread matches above, loose matches on Subject: below --
2016-04-11  0:58 DusonLin
2016-04-19  5:18 DusonLin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160516175342.GD12752@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=agnescheng@google.com \
    --cc=charliemooney@google.com \
    --cc=kt.liao@emc.com.tw \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phoenix@emc.com.tw \
    --cc=zac.hsieh@emc.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).