From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 3/3] input/alps: Add device description for Dell Latitude E7470 Date: Thu, 26 May 2016 11:05:09 +0200 Message-ID: <20160526090509.GE29844@pali> References: <201605251801.45240@pali> <1464252914-11450-1-git-send-email-ben@smart-cactus.org> <1464252914-11450-4-git-send-email-ben@smart-cactus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:32924 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbcEZJFS (ORCPT ); Thu, 26 May 2016 05:05:18 -0400 Received: by mail-wm0-f65.google.com with SMTP id a136so3284935wme.0 for ; Thu, 26 May 2016 02:05:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1464252914-11450-4-git-send-email-ben@smart-cactus.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Ben Gamari Cc: linux-input@vger.kernel.org, Hans de Goede , Allen Hung , Masaki Ota On Thursday 26 May 2016 10:55:14 Ben Gamari wrote: > --- > drivers/input/mouse/alps.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index 10e6836..eb4bf31 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -143,6 +143,7 @@ static const struct alps_model_info alps_model_da= ta[] =3D { > { { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff, > ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } }, /* Toshi= ba Tecra A11-11L */ > { { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } }, > + { { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4= _V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */ > }; > =20 > static const struct alps_protocol_info alps_v3_protocol_data =3D { Hi! I would rather move this code into alps_identify and probably creat= e alps_v8_ss_data structure for it. Above alps_model_data list looks like hooks for special touchpads which needs more flags to work correctly... --=20 Pali Roh=C3=A1r pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html