From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data Date: Tue, 31 May 2016 18:07:41 +0200 Message-ID: <20160531160741.GX23234@mail.corp.redhat.com> References: <1463062363-12405-1-git-send-email-benjamin.tissoires@redhat.com> <1463062363-12405-2-git-send-email-benjamin.tissoires@redhat.com> <1463149818.17131.349.camel@linux.intel.com> <20160513144927.GZ23234@mail.corp.redhat.com> <1463155787.17131.351.camel@linux.intel.com> <1463156908.17131.353.camel@linux.intel.com> <20160520075835.GJ23234@mail.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58845 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbcEaQHq (ORCPT ); Tue, 31 May 2016 12:07:46 -0400 Content-Disposition: inline In-Reply-To: <20160520075835.GJ23234@mail.corp.redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Andy Shevchenko Cc: Jiri Kosina , Bastien Nocera , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On May 20 2016 or thereabouts, Benjamin Tissoires wrote: > On May 13 2016 or thereabouts, Andy Shevchenko wrote: > > On Fri, 2016-05-13 at 19:09 +0300, Andy Shevchenko wrote: > > > On Fri, 2016-05-13 at 16:49 +0200, Benjamin Tissoires wrote: > > > >=20 > > > > On May 13 2016 or thereabouts, Andy Shevchenko wrote: > > > > >=20 > > > > >=20 > > > > > On Thu, 2016-05-12 at 16:12 +0200, Benjamin Tissoires wrote: > > > > > >=20 > > > > > >=20 > > > > > > There is no reasons to filter out keyboard and consumer con= trol > > > > > > collections > > > > > > in hid-multitouch. > > > > > > With the previous hid-input fix, there is now a full suppor= t of > > > > > > the > > > > > > Type > > > > > > Cover and we can remove all specific bits from hid-core and= hid- > > > > > > microsoft. > > > > > >=20 > > > > > > hid-multitouch will automatically set HID_QUIRK_NO_INIT_REP= ORTS > > > > > > so > > > > > > we > > > > > > can > > > > > > also remove it from the list of ushbid quirks. > > > > > >=20 > > > > > > Signed-off-by: Benjamin Tissoires > > > > > > > > > > > > --- > > > > > >=20 > > > > > > Andy, would you mind checking if this series is sufficient = to > > > > > > enable > > > > > > the > > > > > > TypeCover of the Surface Book? > > > > > Tested-by: Andy Shevchenko > > > > >=20 > > > > > Noticed little difference that there is no event for the devi= ce > > > > > anymore, > > > > > just /dev/usb/hiddev0. Would it work properly under X? > > > > Not sure what you mean. > > > > I get 3 input nodes: > > > > Microsoft Surface Type Cover Keyboard > > > > Microsoft Surface Type Cover Consumer Control > > > > Microsoft Surface Type Cover Touchpad > > > >=20 > > > > Each on this input device is properly assigned an event node an= d X > > > > works > > > > with them. > > > >=20 > > > > If there is no /dev/input/eventX created for your cover, then t= his > > > > is > > > > not normal and needs to be investigated. > > > There is no /dev/input/eventX for the touchpad.=C2=A0 > > > It prints that input device is under /usb.../input8, but the actu= al > > > node > > > I got events from is /dev/usb/hiddev0. > >=20 > > Correction, it seems the event node is there (event6), but I got no= thing > > from it >=20 > Would you mind sending me a hid-recorder[1] trace of the device while > typing few keys and using the touchpad? Ping? Without those logs, I can not do further debugging and Jiri can't take = the series... Cheers, Benjamin >=20 > Not receiving events from the actual touchpad node means that the > device did not switch to the mutlitouch mode, or that something else > is going on. I should be able to see that in the hid-recorder log. >=20 >=20 > [1] http://bentiss.github.io/hid-replay-docs/ >=20 > Cheers, > Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html